-
Notifications
You must be signed in to change notification settings - Fork 249
feat: query host to check if dhcp rehydration feature is enabled before issuing dhcp request #3318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
…ending workaround dhcp request if so
a9b913d
to
52b4d42
Compare
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
Pull request closed due to inactivity. |
Reason for Change:
There is a temporary workaround in swiftv2 linux which requires the cni to send a dhcp request when adding secondary nics. A more permanent fix is available, but once that is merged in, cni will still attempt to send the dhcp request and will fail perpetually. This PR adds a check to see if the dhcp rehydration feature (the more permanent fix) is enabled on the host before sending the dhcp request.
Issue Fixed:
See above
Requirements:
Notes:
Only affects swiftv2 linux setups with delegated nics