Skip to content

feat: query host to check if dhcp rehydration feature is enabled before issuing dhcp request #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Jan 7, 2025

Reason for Change:

There is a temporary workaround in swiftv2 linux which requires the cni to send a dhcp request when adding secondary nics. A more permanent fix is available, but once that is merged in, cni will still attempt to send the dhcp request and will fail perpetually. This PR adds a check to see if the dhcp rehydration feature (the more permanent fix) is enabled on the host before sending the dhcp request.

Issue Fixed:

See above

Requirements:

Notes:
Only affects swiftv2 linux setups with delegated nics

@QxBytes QxBytes self-assigned this Jan 7, 2025
@QxBytes QxBytes added cni Related to CNI. swift-v2 labels Jan 7, 2025
@QxBytes QxBytes marked this pull request as ready for review January 10, 2025 21:47
@QxBytes QxBytes requested a review from a team as a code owner January 10, 2025 21:47
@QxBytes QxBytes requested a review from camrynl January 10, 2025 21:47
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Jan 25, 2025
@QxBytes QxBytes removed the stale Stale due to inactivity. label Jan 28, 2025
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Feb 12, 2025
@QxBytes QxBytes removed the stale Stale due to inactivity. label Feb 14, 2025
Copy link

github-actions bot commented Mar 1, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Mar 1, 2025
@QxBytes QxBytes removed the stale Stale due to inactivity. label Mar 3, 2025
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Mar 18, 2025
@QxBytes QxBytes removed the stale Stale due to inactivity. label Mar 18, 2025
Copy link

github-actions bot commented Apr 2, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Apr 2, 2025
@QxBytes QxBytes removed the stale Stale due to inactivity. label Apr 3, 2025
@QxBytes QxBytes force-pushed the alew/detect-dhcp-rehydration-feature branch from a9b913d to 52b4d42 Compare April 16, 2025 17:57
Copy link

github-actions bot commented May 1, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label May 1, 2025
@QxBytes QxBytes removed the stale Stale due to inactivity. label May 5, 2025
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label May 20, 2025
@QxBytes QxBytes removed the stale Stale due to inactivity. label May 20, 2025
Copy link

github-actions bot commented Jun 4, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Jun 4, 2025
Copy link

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Jun 12, 2025
@github-actions github-actions bot deleted the alew/detect-dhcp-rehydration-feature branch June 12, 2025 00:01
@QxBytes QxBytes restored the alew/detect-dhcp-rehydration-feature branch June 13, 2025 00:12
@QxBytes QxBytes reopened this Jun 13, 2025
@QxBytes QxBytes removed the stale Stale due to inactivity. label Jun 13, 2025
@QxBytes QxBytes added the exempt-stale Keep this fresh label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cni Related to CNI. exempt-stale Keep this fresh swift-v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant