Skip to content

fix: add vnetscale staticblock changes to aks makefile #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add vnetscale staticblock changes to aks makefile #3492

wants to merge 1 commit into from

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Mar 10, 2025

The vnetscale-* targets in the AKS Makefile did not have the flag which indicates StaticBlock allocation mode and therefore build normal dynamic podsubnet clusters instead.

Incidentally this means that the VnetScale E2E was not using a VnetScale cluster and this will fix that.

@Copilot Copilot AI review requested due to automatic review settings March 10, 2025 19:40
@rbtr rbtr requested a review from a team as a code owner March 10, 2025 19:40
@rbtr rbtr requested a review from k-routhu March 10, 2025 19:40
Copilot
Copilot AI reviewed Mar 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@rbtr rbtr self-assigned this Mar 10, 2025
@rbtr rbtr added cns Related to CNS. fix Fixes something. vnet-scale PRs related to the Vnet Scale Feature labels Mar 10, 2025
@rbtr
Copy link
Contributor Author

rbtr commented Mar 10, 2025

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr enabled auto-merge March 10, 2025 20:09
@rbtr rbtr added this pull request to the merge queue Mar 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 11, 2025
@rbtr rbtr added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@QxBytes
Copy link
Contributor

QxBytes commented Mar 12, 2025 •
edited
Loading

The vnet scale cluster in the e2e won't create until byocni + vnet scale is enabled in aks rp link to failure (Should be available once the next aks rp releases)

@paulyufan2 paulyufan2 enabled auto-merge March 14, 2025 02:17
@paulyufan2
Copy link
Contributor

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 added this pull request to the merge queue Mar 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2025
@paulyufan2 paulyufan2 added this pull request to the merge queue Mar 14, 2025
@jpayne3506 jpayne3506 removed this pull request from the merge queue due to a manual request Mar 14, 2025
@jpayne3506
Copy link
Contributor

Blocking CI/CD. Wait for next AKS-RP release before adding to merge queue.

@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Mar 29, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Mar 31, 2025
@nairashu
Copy link
Contributor

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Apr 15, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Apr 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label May 2, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label May 2, 2025
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label May 17, 2025
@github-actions GitHub Actions
Copy link

Pull request closed due to inactivity.

@github-actions github-actions bot closed this May 25, 2025
@github-actions github-actions bot deleted the chore/vnet-scale branch May 25, 2025 00:01
@rbtr rbtr added exempt-stale Keep this fresh and removed stale Stale due to inactivity. labels May 29, 2025
@rbtr rbtr restored the chore/vnet-scale branch May 29, 2025 22:54
@rbtr rbtr reopened this May 29, 2025
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Jun 13, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@nairashu nairashu nairashu approved these changes

@vakalapa vakalapa vakalapa approved these changes

@k-routhu k-routhu Awaiting requested review from k-routhu k-routhu is a code owner automatically assigned from Azure/azure-sdn-members

@neaggarwMS neaggarwMS Awaiting requested review from neaggarwMS

@thatmattlong thatmattlong Awaiting requested review from thatmattlong

Assignees

@rbtr rbtr

Labels
cns Related to CNS. exempt-stale Keep this fresh fix Fixes something. vnet-scale PRs related to the Vnet Scale Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rbtr @QxBytes @paulyufan2 @jpayne3506 @nairashu @vakalapa