ci: use publish code coverage results v1 #3647
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QxBytes
changed the title
QxBytes
changed the title
QxBytes
changed the title
|
/azp run Azure Container Networking |
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI pipeline for Azure Container Networking to use Publish Code Coverage Results v1 instead of v2 due to multi-file report limitations and removes Windows coverage steps from the pipeline.
- Removed Windows-specific pipeline tasks (artifact download, coverage conversion, and report migration).
- Downgraded the publish code coverage task to version 1 and updated its configuration accordingly.
Comments suppressed due to low confidence (1)
.pipelines/templates/run-unit-tests.yaml:75
- Removal of Windows coverage tasks means only Linux builds are covered; ensure this change aligns with the intended CI coverage requirements.
- GOOS=windows gocov convert windows-coverage.out > windows-coverage.json
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pjohnst5
requested changes
May 9, 2025
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pjohnst5
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Use publish code coverage results v1 until v2 bug is fixed. Code coverage v1 does not support multi file coverage reports and merging the two files does not give the expected result (depending on the GOOS during gocov, os-specific files are included/excluded from the report).
Will re add the windows ut coverage after v2 fix is out.
Green run: https://msazure.visualstudio.com/One/_build/results?buildId=123636014&view=results
Issue Fixed:
Requirements:
Notes: