ci: add azure ip masq merger to pipeline #3739
Open
+138
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…line todo: add azureIpMasqMergerVersion pipeline version somewhere
tested merged config live cluster with tcpdump
QxBytes
force-pushed
the
alew/add-azure-ip-masq-merger-pipeline
branch
from
e163f81 to
72cc8c6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the azure-ip-masq-merger into the CI pipelines so that its binary is built and published alongside existing components.
- Added a README with usage and configuration instructions for the azure-ip-masq-merger.
- Updated Dockerfiles for both Linux and Windows images to reference the new binary name.
- Modified pipeline YAML files and build scripts to include azure-ip-masq-merger build and packaging steps.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| azure-ip-masq-merger/README.md | Added documentation describing the tool’s purpose, usage, and config. |
| azure-ip-masq-merger/Dockerfile | Updated Dockerfile to copy and set the proper binary name and entrypoint. |
| .pipelines/run-pipeline.yaml | Added environment variables and job definitions for the new merger build. |
| .pipelines/pipeline.yaml | Included definitions for additional build jobs (architecture-specific). |
| .pipelines/build/scripts/azure-ip-masq-merger.sh | New build script for compiling the azure-ip-masq-merger binary. |
| .pipelines/build/ob-prepare.steps.yaml | Added steps to set the azure-ip-masq-merger version variable. |
| .pipelines/build/dockerfiles/azure-ip-masq-merger.Dockerfile | New Dockerfile for building a minimal container image for the merger. |
QxBytes
force-pushed
the
alew/add-azure-ip-masq-merger-pipeline
branch
from
047b1a2 to
d9541a4
Compare
santhoshmprabhu
approved these changes
Jun 18, 2025
jpayne3506
reviewed
Jun 20, 2025
Comment on lines
-24
to
-26
| FROM mcr.microsoft.com/oss/kubernetes/windows-host-process-containers-base-image@sha256:b4c9637e032f667c52d1eccfa31ad8c63f1b035e8639f3f48a510536bf34032b as windows | ||
| COPY --from=azure-ip-masq-merger /go/bin/ip-masq-merger ip-masq-merger.exe | ||
| ENTRYPOINT [ "/ip-masq-merger.exe" ] |
There was a problem hiding this comment.
No windows support means you can remove OS_VERSION from this Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adds building the azure ip masq merger to the signed and unsigned binaries pipelines. Merge once #3737 has merged in.
Issue Fixed:
Requirements:
Notes:
ACN PR Run Before Rebase: https://msazure.visualstudio.com/One/_build/results?buildId=127562678&view=results
ACN PR Run Latest: https://msazure.visualstudio.com/One/_build/results?buildId=127597027&view=results
ACN Official Build Signed: https://dev.azure.com/msazure/One/_build/results?buildId=127600651&view=results