PR comments - remove unsupported tests and scope client

Azure · Jun 22, 2023 · 9b396f7 · 9b396f7
1 parent 5a3f53c
commit 9b396f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 16 deletions.
diff --git a/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/HeadersValidationTests.cs b/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/HeadersValidationTests.cs
@@ -206,14 +206,14 @@ private async Task ValidateConsistencyLevel(DocumentClient client)
         [TestMethod]
         public void ValidateJsonSerializationFormatGateway()
         {
-            var client = TestCommon.CreateClient(true);
+            using var client = TestCommon.CreateClient(true);
             ValidateJsonSerializationFormat(client);
         }
 
         [TestMethod]
         public void ValidateJsonSerializationFormatRntbd()
         {
-            var client = TestCommon.CreateClient(false, Protocol.Tcp);
+            using var client = TestCommon.CreateClient(false, Protocol.Tcp);
             ValidateJsonSerializationFormat(client);
         }
 
@@ -309,24 +309,17 @@ private void ValidateJsonSerializationFormatQuery(DocumentClient client, Documen
         [TestMethod]
         public void ValidateSupportedSerializationFormatsGateway()
         {
-            DocumentClient client = TestCommon.CreateClient(true);
+            using var client = TestCommon.CreateClient(true);
             this.ValidateSupportedSerializationFormats(client, true);
         }
 
         [TestMethod]
         public void ValidateSupportedSerializationFormatsRntbd()
         {
-            DocumentClient client = TestCommon.CreateClient(false, Protocol.Tcp);
+            using var client = TestCommon.CreateClient(false, Protocol.Tcp);
             this.ValidateSupportedSerializationFormats(client, false);
         }
 
-        [TestMethod]
-        public void ValidateSupportedSerializationFormatsHttps()
-        {
-            DocumentClient client = TestCommon.CreateClient(false, Protocol.Https);
-            this.ValidateSupportedSerializationFormats(client, true);
-        }
-
         private void ValidateSupportedSerializationFormats(DocumentClient client, bool isHttps)
         {
             DocumentCollection collection = TestCommon.CreateOrGetDocumentCollection(client);

diff --git a/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/BinaryEncodingOverTheWireTests.cs b/Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/BinaryEncodingOverTheWireTests.cs
@@ -28,15 +28,11 @@ public class BinaryEncodingOverTheWireTests
             ConfigurationManager.AppSettings["GatewayEndpoint"],
             ConfigurationManager.AppSettings["MasterKey"],
             new CosmosClientOptions() { ConnectionMode = ConnectionMode.Gateway });
-        private static readonly CosmosClient DirectHttpsClient = new CosmosClient(
-            ConfigurationManager.AppSettings["GatewayEndpoint"],
-            ConfigurationManager.AppSettings["MasterKey"],
-            new CosmosClientOptions() { ConnectionMode = ConnectionMode.Direct, ConnectionProtocol = Documents.Client.Protocol.Https });
         private static readonly CosmosClient RntbdClient = new CosmosClient(
             ConfigurationManager.AppSettings["GatewayEndpoint"],
             ConfigurationManager.AppSettings["MasterKey"],
             new CosmosClientOptions() { ConnectionMode = ConnectionMode.Direct, ConnectionProtocol = Documents.Client.Protocol.Tcp });
-        private static readonly CosmosClient[] Clients = new CosmosClient[] { GatewayClient, DirectHttpsClient, RntbdClient };
+        private static readonly CosmosClient[] Clients = new CosmosClient[] { GatewayClient, RntbdClient };
         private static readonly CosmosClient Client = RntbdClient;
         private static readonly AsyncLazy<Database> Database = new AsyncLazy<Database>(async () =>
         {