Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics with metrics #3914

Closed
wants to merge 78 commits into from
Closed

Diagnostics with metrics #3914

wants to merge 78 commits into from

Conversation

tangerinous
Copy link
Contributor

@tangerinous tangerinous commented Jun 14, 2023

[Internal]Cosmos DB Benchmarking on VM based model which aims to simplify the process

Description

According to the issue the goal of this feature is to make the process of using the CosmosDB benchmarking tools as easy as possible for our customers. Here we are looking to use ARM templates to deploy and run our benchmarking.
Here we will switch to a VM based model which aims to simplify the process and reduce costs. Here we will also add more features:

  • Ability to execute benchmarking on multiple machines with one ARM Template
  • Include more input parameters for testing features such as - ClientTelemetry and DistributedTracing
  • Include extensive logs with full diagnostics
  • AppInsights: Live metrics (10s)
    • Success rate
    • Error
    • P90, P99, P999, P9999

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

David Chaava added 30 commits May 25, 2023 15:35
…hmark/azuredeploy.json

	modified:   Microsoft.Azure.Cosmos.Samples/Tools/Benchmark/AzureVmBenchmark/system/cloud-init.txt
…hmark/azuredeploy.json

	modified:   Microsoft.Azure.Cosmos.Samples/Tools/Benchmark/AzureVmBenchmark/scripts/custom-script.sh
	modified:   Microsoft.Azure.Cosmos.Samples/Tools/Benchmark/AzureVmBenchmark/system/cloud-init.txt
…hmark/scripts/custom-script.sh

	modified:   Microsoft.Azure.Cosmos.Samples/Tools/Benchmark/AzureVmBenchmark/system/cloud-init.txt
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@kundadebdatta
Copy link
Member

Please split this PR into 2 parts, one specifically for the diagnostics work and the other one is for the metrics work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants