-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Query: Removes Ode changes which rejected certain types of queries which were previously supported on 3.36.0 #4146
Merged
microsoft-github-policy-service
merged 3 commits into
releases/3.36.0
from
users/akotalwar/RevertODEChangesOnRelease
Oct 22, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akotalwar
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
October 20, 2023 20:13
akotalwar
changed the title
[Internal] Query: Removes Ode changes which rejected certain types of queries which were previously supported
[Internal] Query: Removes Ode changes which rejected certain types of queries which were previously supported on 3.36.0
Oct 20, 2023
neildsh
changed the title
[Internal] Query: Removes Ode changes which rejected certain types of queries which were previously supported on 3.36.0
[Internal] Query: Revert Optimistic Direct Execution changes which rejected certain types of queries which were previously supported on 3.36.0
Oct 20, 2023
neildsh
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
akotalwar
changed the title
[Internal] Query: Revert Optimistic Direct Execution changes which rejected certain types of queries which were previously supported on 3.36.0
[Internal] Query: Removes Ode changes which rejected certain types of queries which were previously supported on 3.36.0
Oct 20, 2023
Maya-Painter
approved these changes
Oct 20, 2023
adityasa
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sboshra
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
microsoft-github-policy-service
bot
merged commit Oct 22, 2023
3f48041
into
releases/3.36.0
20 checks passed
microsoft-github-policy-service
bot
deleted the
users/akotalwar/RevertODEChangesOnRelease
branch
October 22, 2023 18:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Changes made to the Ode code path have caused existing behavior to break with the Passthrough pipeline.
This is because, queries that the Passthrough pipeline would support are no longer supported due to Ode causing customer queries to suddenly stop working.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber