Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Query: Removes Ode changes which rejected certain types of queries which were previously supported on 3.36.0 #4146

Conversation

akotalwar
Copy link
Contributor

Pull Request Template

Description

Changes made to the Ode code path have caused existing behavior to break with the Passthrough pipeline.
This is because, queries that the Passthrough pipeline would support are no longer supported due to Ode causing customer queries to suddenly stop working.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@akotalwar akotalwar changed the title [Internal] Query: Removes Ode changes which rejected certain types of queries which were previously supported [Internal] Query: Removes Ode changes which rejected certain types of queries which were previously supported on 3.36.0 Oct 20, 2023
@neildsh neildsh changed the title [Internal] Query: Removes Ode changes which rejected certain types of queries which were previously supported on 3.36.0 [Internal] Query: Revert Optimistic Direct Execution changes which rejected certain types of queries which were previously supported on 3.36.0 Oct 20, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@akotalwar akotalwar changed the title [Internal] Query: Revert Optimistic Direct Execution changes which rejected certain types of queries which were previously supported on 3.36.0 [Internal] Query: Removes Ode changes which rejected certain types of queries which were previously supported on 3.36.0 Oct 20, 2023
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@akotalwar akotalwar added the auto-merge Enables automation to merge PRs label Oct 22, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 3f48041 into releases/3.36.0 Oct 22, 2023
20 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/akotalwar/RevertODEChangesOnRelease branch October 22, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants