Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.36.0: Fixes Preview Pipeline and Client Config Test #4148

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Release 3.36.0: Fixes Preview Pipeline and Client Config Test #4148

merged 2 commits into from
Oct 23, 2023

Conversation

sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Oct 23, 2023 •
edited
Loading

Description

As part of this PR, we are fixing below 2 things:

  1. Fixing preview release pipeline where it is find out that, this pipeline was never taking the passed variables.
  2. ClientConfig test is fixed on preview package. As distributedtracingId is also added.

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)

@sourabh1007 sourabh1007 changed the base branch from master to releases/3.36.0-preview October 23, 2023 01:09
@sourabh1007 sourabh1007 added the auto-merge Enables automation to merge PRs label Oct 23, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit f329f1c into releases/3.36.0-preview Oct 23, 2023
26 of 29 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/sourabhjain/pipelinefixonpreview branch October 23, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipthomas-MSFT philipthomas-MSFT philipthomas-MSFT approved these changes

@ealsur ealsur ealsur approved these changes

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees
No one assigned
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sourabh1007 @ealsur @philipthomas-MSFT