Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Adds support for multi-value Group By query for LINQ #4481

Merged
merged 19 commits into from
Jul 9, 2024
Merged

Query: Adds support for multi-value Group By query for LINQ #4481

merged 19 commits into from
Jul 9, 2024

Conversation

leminh98
Copy link
Contributor

@leminh98 leminh98 commented May 13, 2024 •
edited
Loading

Pull Request Template

Description

This PR adds the ability to translate LINQ query to SQL query with multiple items in the SQL select clause. This is achieved through the value clause using NewExpression

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@leminh98 leminh98 added QUERY auto-merge Enables automation to merge PRs labels May 13, 2024
@bartelink
Copy link
Contributor

Semi-related issues in case they are easy to address in the same block of work:

@leminh98 leminh98 mentioned this pull request May 13, 2024
Open
adityasa
adityasa requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Minh Le (from Dev Box) and others added 3 commits May 21, 2024 03:17
address code review 1
f6ab78c
Changed the way comparison between Anonymoustype object worked. Also …
49afa87 
…added handling of multivalue case to call directly to leaf layer visitors, instead of going through the top level scalar expression visitor to avoid changing binding and context scope
@leminh98
Merge branch 'master' into users/leminh/LINQGroupByMultiValue
10c1fd8
adityasa
adityasa previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

adityasa
adityasa previously approved these changes Jul 2, 2024
View reviewed changes
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 5bba9a0 into master Jul 9, 2024
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/leminh/LINQGroupByMultiValue branch July 9, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maya-Painter Maya-Painter Maya-Painter approved these changes

@adityasa adityasa adityasa approved these changes

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@ealsur ealsur Awaiting requested review from ealsur

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees
No one assigned
Labels
auto-merge Enables automation to merge PRs QUERY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leminh98 @bartelink @adityasa @Maya-Painter