Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Query: Adds alias support to GroupByClause in SQL DOM #4487

Closed
wants to merge 3 commits into from
Closed

[Internal] Query: Adds alias support to GroupByClause in SQL DOM #4487

wants to merge 3 commits into from

Conversation

leminh98
Copy link
Contributor

@leminh98 leminh98 commented May 14, 2024 •
edited
Loading

Pull Request Template

Description

This PR adds support for alias in GroupBy clause in the SQL DOM

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

github-actions[bot]
github-actions bot reviewed May 14, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@leminh98 leminh98 changed the title [Internal] Query [Internal] Query: Adds alias support to GroupByExpression in SQL DOM May 14, 2024
@leminh98 leminh98 changed the title [Internal] Query: Adds alias support to GroupByExpression in SQL DOM [Internal] Query: Adds alias support to GroupByClause in SQL DOM May 14, 2024
@leminh98 leminh98 closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@ealsur ealsur Awaiting requested review from ealsur

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leminh98