-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Adds Distribution for MakeList and MakeSet #4490
Merged
microsoft-github-policy-service
merged 24 commits into
master
from
users/ezrahaleva/MakeListDistribution
Jun 20, 2024
Merged
Query: Adds Distribution for MakeList and MakeSet #4490
microsoft-github-policy-service
merged 24 commits into
master
from
users/ezrahaleva/MakeListDistribution
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrahaleva-msft
requested review from
adityasa,
neildsh,
kirankumarkolli and
sboshra
as code owners
May 14, 2024 14:26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
khdang
reviewed
May 16, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs
Show resolved
Hide resolved
khdang
reviewed
May 16, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs
Outdated
Show resolved
Hide resolved
ezrahaleva-msft
force-pushed
the
users/ezrahaleva/MakeListDistribution
branch
from
May 24, 2024 16:03
a051c76
to
db1872a
Compare
ezrahaleva-msft
requested review from
ealsur,
FabianMeiswinkel and
kirillg
as code owners
May 24, 2024 16:03
khdang
reviewed
May 27, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Outdated
Show resolved
Hide resolved
khdang
reviewed
May 27, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Outdated
Show resolved
Hide resolved
khdang
reviewed
May 27, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Outdated
Show resolved
Hide resolved
khdang
reviewed
May 27, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Show resolved
Hide resolved
khdang
reviewed
May 27, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Show resolved
Hide resolved
khdang
reviewed
May 27, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Outdated
Show resolved
Hide resolved
khdang
reviewed
May 27, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Show resolved
Hide resolved
khdang
reviewed
May 27, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Outdated
Show resolved
Hide resolved
khdang
reviewed
Jun 5, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Outdated
Show resolved
Hide resolved
khdang
reviewed
Jun 5, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Outdated
Show resolved
Hide resolved
khdang
reviewed
Jun 5, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs
Show resolved
Hide resolved
khdang
reviewed
Jun 5, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs
Show resolved
Hide resolved
neildsh
reviewed
Jun 17, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeSetAggregator.cs
Show resolved
Hide resolved
neildsh
reviewed
Jun 17, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs
Show resolved
Hide resolved
neildsh
reviewed
Jun 17, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs
Outdated
Show resolved
Hide resolved
neildsh
reviewed
Jun 17, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeSetAggregator.cs
Outdated
Show resolved
Hide resolved
neildsh
reviewed
Jun 17, 2024
...rosoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.AggregateMixedTypes_baseline.xml
Outdated
Show resolved
Hide resolved
neildsh
reviewed
Jun 17, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Show resolved
Hide resolved
neildsh
reviewed
Jun 17, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs
Outdated
Show resolved
Hide resolved
neildsh
reviewed
Jun 17, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs
Show resolved
Hide resolved
ezrahaleva-msft
changed the title
Distribution for MakeList and MakeSet
Query: Distribution for MakeList and MakeSet
Jun 19, 2024
ezrahaleva-msft
changed the title
Query: Distribution for MakeList and MakeSet
Adds Distribution for MakeList and MakeSet
Jun 19, 2024
ezrahaleva-msft
changed the title
Adds Distribution for MakeList and MakeSet
Query: Adds Distribution for MakeList and MakeSet
Jun 19, 2024
sboshra
reviewed
Jun 19, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Jun 19, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs
Show resolved
Hide resolved
sboshra
previously approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
khdang
approved these changes
Jun 20, 2024
sboshra
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ezrahaleva-msft
force-pushed
the
users/ezrahaleva/MakeListDistribution
branch
from
June 20, 2024 22:23
dbbb07f
to
be853ce
Compare
microsoft-github-policy-service
bot
deleted the
users/ezrahaleva/MakeListDistribution
branch
June 20, 2024 23:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds MakeList and MakeSet aggregate operators and implements MakeListAggregator and MakeSetAggregator.
Type of change