Query: Fixes Persisted continuationToken issue by turning off ODE by default (#4413) and Fixes bug in OrderByCrossPartitionQueryPipelineStage to ensure that errors in inner pipeline creation are bubbled up (#4419) #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasa
changed the title
…default (#4413) * Turn of ODE by default. * Updated tests * Update * Test fix * Added test for query resumption with ODE token with partition split container (failure case). * Update. * Update Benchmark * Addressed comments.
adityasa
force-pushed
the
users/adityasa/CherryPickODERevert
branch
from
335eb16
to
cd36a56
Compare
adityasa
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
neildsh
previously approved these changes
May 16, 2024
|
This PR is now no-op since another change subsumed all cherry picks that were intended to go in as part of this change:
|
auto-merge was automatically disabled
May 16, 2024 00:43
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Cherry-pick of merged pr:
#4413
Also contains cherry-pick of:
08338af
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber