FaultInjection: Refactors applyPercentage name to injectionRate to make feature clearer. #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
ealsur
approved these changes
May 21, 2024
kundadebdatta
approved these changes
May 21, 2024
Looks like they are from some flaky tests. They seem to be failing on other PRs too and I have seen these randomly fail before. I will rerun the test a few more time to double check but currently there are no tests that rely on this. |
kirankumarkolli
approved these changes
May 22, 2024
microsoft-github-policy-service
bot
deleted the
users/nalutripician/faultInjectionInjectionRate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Changed the name of the ApplyPercentage feature to InjectionRate. This should make the function of the feature clearer to users. This will also be the name of the feature in the Java SDK.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber