Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Tests : Fixes enable "warning-as-error" build errors #4588

Merged
merged 10 commits into from
Oct 3, 2024
Merged

[Internal] Tests : Fixes enable "warning-as-error" build errors #4588

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
766af53
Fixes `dotnet test` below issues
kirankumarkolli May 17, 2024
63377d7
Merge branch 'master' into users/kirankk/ut_fixes
kirankumarkolli Sep 17, 2024
c2b78ed
Merge branch 'master' into users/kirankk/ut_fixes
kirankumarkolli Sep 25, 2024
e02091b
Merge branch 'master' into users/kirankk/ut_fixes
kirankumarkolli Oct 2, 2024
ff16ab6
refreshing file
kirankumarkolli Oct 2, 2024
8b0f368
Addressing new warnings
kirankumarkolli Oct 2, 2024
336a9d5
Addressing some more issues
kirankumarkolli Oct 2, 2024
1e43207
Merge branch 'master' into users/kirankk/ut_fixes
kirankumarkolli Oct 2, 2024
a805c35
Renmaing method with Async suffix
kirankumarkolli Oct 2, 2024
03ab87f
Adding Async suffix to the helper method as well
kirankumarkolli Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ....Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/NonStreamingOrderByQueryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,9 @@ private sealed class Document

private static class DebugTraceHelpers
{
#pragma warning disable CS0162, CS0649 // Unreachable code detected
private const bool Enabled = false;

#pragma warning disable CS0162 // Unreachable code detected
public static void TraceSupportedFeaturesString(string supportedQueryFeatures)
{
if (Enabled)
Expand Down
6 changes: 6 additions & 0 deletions ...crosoft.Azure.Cosmos.Tests/ChangeFeed/ChangeFeedPartitionKeyResultSetIteratorCoreTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public async Task EtagPassesContinuation()

Mock<ContainerInternal> containerMock = new Mock<ContainerInternal>();
Mock<CosmosClientContext> mockContext = new Mock<CosmosClientContext>();
#pragma warning disable CA1416 // 'ResourceType' is only supported on: 'windows'
mockContext.Setup(x => x.OperationHelperAsync<ResponseMessage>(
It.Is<string>(str => str.Contains("Change Feed Processor")),
It.IsAny<string>(),
Expand All @@ -59,6 +60,7 @@ public async Task EtagPassesContinuation()
return func(trace);
}
});
#pragma warning restore CA1416

mockContext.Setup(c => c.ProcessResourceOperationStreamAsync(
It.IsAny<string>(),
Expand Down Expand Up @@ -121,6 +123,7 @@ public async Task NextReadHasUpdatedContinuation()

Mock<ContainerInternal> containerMock = new Mock<ContainerInternal>();
Mock<CosmosClientContext> mockContext = new Mock<CosmosClientContext>();
#pragma warning disable CA1416 // 'ResourceType' is only supported on: 'windows'
mockContext.Setup(x => x.OperationHelperAsync<ResponseMessage>(
It.Is<string>(str => str.Contains("Change Feed Processor")),
It.IsAny<string>(),
Expand All @@ -140,6 +143,7 @@ public async Task NextReadHasUpdatedContinuation()
return func(trace);
}
});
#pragma warning restore CA1416

mockContext.SetupSequence(c => c.ProcessResourceOperationStreamAsync(
It.IsAny<string>(),
Expand Down Expand Up @@ -192,6 +196,7 @@ public async Task ShouldSetFeedRangePartitionKeyRange()

Mock<ContainerInternal> containerMock = new Mock<ContainerInternal>();
Mock<CosmosClientContext> mockContext = new Mock<CosmosClientContext>();
#pragma warning disable CA1416 // 'ResourceType' is only supported on: 'windows'
mockContext.Setup(x => x.OperationHelperAsync<ResponseMessage>(
It.Is<string>(str => str.Contains("Change Feed Processor")),
It.IsAny<string>(),
Expand All @@ -211,6 +216,7 @@ public async Task ShouldSetFeedRangePartitionKeyRange()
return func(trace);
}
});
#pragma warning restore CA1416

mockContext.Setup(c => c.ProcessResourceOperationStreamAsync(
It.IsAny<string>(),
Expand Down
32 changes: 16 additions & 16 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/ClientRetryPolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,51 +270,51 @@ public void HttpRequestExceptionHandelingTests(
}

[TestMethod]
public Task ClientRetryPolicy_Retry_SingleMaster_Read_PreferredLocations()
public async Task ClientRetryPolicy_Retry_SingleMaster_Read_PreferredLocationsAsync()
{
return this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: true, useMultipleWriteLocations: false, usesPreferredLocations: true, shouldHaveRetried: true);
await this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: true, useMultipleWriteLocations: false, usesPreferredLocations: true, shouldHaveRetried: true);
}

[TestMethod]
public Task ClientRetryPolicy_Retry_MultiMaster_Read_PreferredLocations()
public async Task ClientRetryPolicy_Retry_MultiMaster_Read_PreferredLocationsAsync()
{
return this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: true, useMultipleWriteLocations: true, usesPreferredLocations: true, shouldHaveRetried: true);
await this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: true, useMultipleWriteLocations: true, usesPreferredLocations: true, shouldHaveRetried: true);
}

[TestMethod]
public Task ClientRetryPolicy_Retry_MultiMaster_Write_PreferredLocations()
public async Task ClientRetryPolicy_Retry_MultiMaster_Write_PreferredLocationsAsync()
{
return this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: false, useMultipleWriteLocations: true, usesPreferredLocations: true, shouldHaveRetried: true);
await this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: false, useMultipleWriteLocations: true, usesPreferredLocations: true, shouldHaveRetried: true);
}

[TestMethod]
public Task ClientRetryPolicy_NoRetry_SingleMaster_Write_PreferredLocations()
public async Task ClientRetryPolicy_NoRetry_SingleMaster_Write_PreferredLocationsAsync()
{
return this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: false, useMultipleWriteLocations: false, usesPreferredLocations: true, shouldHaveRetried: false);
await this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: false, useMultipleWriteLocations: false, usesPreferredLocations: true, shouldHaveRetried: false);
}

[TestMethod]
public Task ClientRetryPolicy_NoRetry_SingleMaster_Read_NoPreferredLocations()
public async Task ClientRetryPolicy_NoRetry_SingleMaster_Read_NoPreferredLocationsAsync()
{
return this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: true, useMultipleWriteLocations: false, usesPreferredLocations: false, shouldHaveRetried: false);
await this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: true, useMultipleWriteLocations: false, usesPreferredLocations: false, shouldHaveRetried: false);
}

[TestMethod]
public Task ClientRetryPolicy_NoRetry_SingleMaster_Write_NoPreferredLocations()
public async Task ClientRetryPolicy_NoRetry_SingleMaster_Write_NoPreferredLocationsAsync()
{
return this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: false, useMultipleWriteLocations: false, usesPreferredLocations: false, shouldHaveRetried: false);
await this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: false, useMultipleWriteLocations: false, usesPreferredLocations: false, shouldHaveRetried: false);
}

[TestMethod]
public Task ClientRetryPolicy_NoRetry_MultiMaster_Read_NoPreferredLocations()
public async Task ClientRetryPolicy_NoRetry_MultiMaster_Read_NoPreferredLocationsAsync()
{
return this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: true, useMultipleWriteLocations: true, usesPreferredLocations: false, false);
await this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: true, useMultipleWriteLocations: true, usesPreferredLocations: false, false);
}

[TestMethod]
public Task ClientRetryPolicy_NoRetry_MultiMaster_Write_NoPreferredLocations()
public async Task ClientRetryPolicy_NoRetry_MultiMaster_Write_NoPreferredLocationsAsync()
{
return this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: false, useMultipleWriteLocations: true, usesPreferredLocations: false, false);
await this.ValidateConnectTimeoutTriggersClientRetryPolicy(isReadRequest: false, useMultipleWriteLocations: true, usesPreferredLocations: false, false);
}

private async Task ValidateConnectTimeoutTriggersClientRetryPolicy(
kirankumarkolli marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 2 additions & 0 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosClientOptionsUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,8 +1110,10 @@ public void TestServerCertificatesValidationWithDisableSSLFlagTrue(string connSt
CosmosHttpClient httpClient = cosmosClient.DocumentClient.httpClient;
SocketsHttpHandler socketsHttpHandler = (SocketsHttpHandler)httpClient.HttpMessageHandler;

#nullable enable
RemoteCertificateValidationCallback? httpClientRemoreCertValidationCallback = socketsHttpHandler.SslOptions.RemoteCertificateValidationCallback;
Assert.IsNotNull(httpClientRemoreCertValidationCallback);
#nullable disable
}

private class TestWebProxy : IWebProxy
Expand Down
1 change: 1 addition & 0 deletions ...osoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Microsoft.Azure.Cosmos.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<RootNamespace>Microsoft.Azure.Cosmos.Tests</RootNamespace>
<LangVersion>$(LangVersion)</LangVersion>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions ...Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Query/Pipeline/NonStreamingOrderByQueryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,8 +727,8 @@ private async Task SplitMergeAsync()

private static class DebugTraceHelpers
{
private const bool Enabled = false;
#pragma warning disable CS0162 // Unreachable code detected
#pragma warning disable CS0162, CS0649 // Unreachable code detected
private static readonly bool Enabled;

[Conditional("DEBUG")]
public static void TraceSplit(FeedRangeInternal feedRange)
Expand Down
2 changes: 2 additions & 0 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Routing/PartitionKeyHash.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,12 @@ public override bool Equals(object obj)
return false;
}

#pragma warning disable CA2013 // value boxing, also this check seems redundant (future todo)
if (object.ReferenceEquals(this, obj))
{
return true;
}
#pragma warning restore CA2013

return this.Equals(effectivePartitionKey);
}
Expand Down
Loading