SystemTextJsonSerializer: Adds UseSystemTextJsonSerializerWithOptions in CosmosClientOptions to Set the Default STJ Serializer
#4589
Conversation
kundadebdatta
requested review from
a team,
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
Microsoft.Azure.Cosmos/src/Serializer/CosmosSystemTextJsonSerializer.cs
Outdated
Show resolved
Hide resolved
kundadebdatta
dismissed stale reviews from Pilchie, NaluTripician, and kirankumarkolli
via
93a0f9c
|
Maybe change the title of the PR? |
There was a problem hiding this comment.
Looks pretty good. A few suggestions, and agree with the name proposal in @kirankumarkolli's review.
.../tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqAggregateCustomSerializationBaseline.cs
Show resolved
Hide resolved
...os/tests/Microsoft.Azure.Cosmos.EmulatorTests/LinqTranslationWithCustomSerializerBaseline.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/CosmosClientOptionsUnitTests.cs
Show resolved
Hide resolved
kirankumarkolli
deleted the
users/kundadebdatta/make_stj_serializer_public
branch
|
Hooray! 🎆 Looking forward to deleting the copies of that code that I've been littering in my projects ;) |
|
Any hope this will make 3.43.0? I very much appreciate this PR by the way, I'm looking forward to it! |
kundadebdatta
changed the title
SystemTextJsonSerializerOptions to Set the Default STJ SerializerUseSystemTextJsonSerializerWithOptions to Set the Default STJ Serializer
kirankumarkolli
changed the title
UseSystemTextJsonSerializerWithOptions to Set the Default STJ SerializerUseSystemTextJsonSerializerWithOptions to Set the Default STJ Serializer
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
kirankumarkolli
changed the title
UseSystemTextJsonSerializerWithOptions to Set the Default STJ SerializerUseSystemTextJsonSerializerWithOptions to Set the Default STJ Serializer
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
kundadebdatta
changed the title
UseSystemTextJsonSerializerWithOptions to Set the Default STJ SerializerUseSystemTextJsonSerializerWithOptions in CosmosClientOptions to Set the Default STJ Serializer
Pull Request Template
Description
This PR refactors Code to Introduce
UseSystemTextJsonSerializerWithOptionsparameter in theCosmosClientOptionsto Set the Default STJ Serializer for bothpreviewandGArelease. To read more about the default serializer, please refer to this PR.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber