[Internal] Client Telemetry: Fixes loggers #4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
j82w
reviewed
Jul 21, 2024
Microsoft.Azure.Cosmos/src/Telemetry/Collector/TelemetryCollector.cs
Outdated
Show resolved
Hide resolved
bartelink
reviewed
Jul 22, 2024
… throw an exception, while recording it
sourabh1007
force-pushed
the
users/sourabhjain/fixclienttelemetrybug
branch
2 times, most recently
from
4f8b0eb
to
b7bd57e
Compare
sourabh1007
force-pushed
the
users/sourabhjain/fixclienttelemetrybug
branch
from
b7bd57e
to
d4780f6
Compare
sourabh1007
changed the title
NaluTripician
approved these changes
Jul 24, 2024
kirankumarkolli
approved these changes
Jul 24, 2024
bartelink
reviewed
Jul 24, 2024
| @@ -42,7 +42,7 @@ public void CollectCacheInfo(string cacheName, Func<TelemetryInformation> functi | |||
| } | |||
| catch (Exception ex) | |||
| { | |||
| DefaultTrace.TraceError($"Error while collecting cache {0} telemetry. Exception : {1}", cacheName, ex); | |||
| DefaultTrace.TraceError("Error while collecting cache {0} telemetry. Exception : {1}", cacheName, ex); | |||
There was a problem hiding this comment.
if there's an overload that takes the ex arg first, that should be used instead (same for others)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR would fix this issue: #4592
Type of change
Closing issues
To automatically close an issue: closes #4592