Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Query: Removes unused code and simplifies query pipeline classes #4601

Merged
merged 8 commits into from
Jul 26, 2024

Conversation

neildsh
Copy link
Contributor

@neildsh neildsh commented Jul 23, 2024

Pull Request Template

Description

This change continues the code cleanup to remove unused code and simplify the query pipeline. Since #4558 remove the compute specific classes, we no longer need the aggregate stages to be partial classes. Hence, we remove the unnecessary code and consolidate the query pipeline classes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@neildsh neildsh changed the title Query: Consolidate and simplify query pipeline classes and remove unused code [Internal] Query: Removes unused code and simplifies query pipeline classes Jul 23, 2024
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@neildsh neildsh added QUERY auto-merge Enables automation to merge PRs labels Jul 26, 2024
@kirankumarkolli kirankumarkolli merged commit 7d7269b into master Jul 26, 2024
21 checks passed
@kirankumarkolli kirankumarkolli deleted the users/ndeshpan/cleanup branch July 26, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs QUERY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants