-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Query: Removes unused code and simplifies query pipeline classes #4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neildsh
requested review from
adityasa,
kirankumarkolli and
sboshra
as code owners
July 23, 2024 19:59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
neildsh
changed the title
Query: Consolidate and simplify query pipeline classes and remove unused code
[Internal] Query: Removes unused code and simplifies query pipeline classes
Jul 23, 2024
neildsh
force-pushed
the
users/ndeshpan/cleanup
branch
from
July 24, 2024 22:57
9a9ad23
to
c48d8e1
Compare
neildsh
requested review from
khdang,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
July 24, 2024 22:57
sboshra
reviewed
Jul 25, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/AggregateQueryPipelineStage.cs
Show resolved
Hide resolved
sboshra
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leminh98
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This change continues the code cleanup to remove unused code and simplify the query pipeline. Since #4558 remove the compute specific classes, we no longer need the aggregate stages to be partial classes. Hence, we remove the unnecessary code and consolidate the query pipeline classes