Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Telemetry: Adds Batchsize and Rename Batch Operation name in Operation Trace #4622

Merged

Conversation

sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Aug 2, 2024

Description

Cosmetic Changes:
Refer, https://opentelemetry.io/docs/specs/semconv/database/cosmosdb/

  1. db.operation => db.operation.name
  2. db.name => db.namespace
  3. db.cosmosdb.container => db.collection.name

Functional Changes:

  1. Add new Attributes as db.operation.batch.size
  2. Operation name should be prepended with BATCH for homogenous operations, or be just BATCH for heterogenous operations.

Type of change

  • [] New feature (non-breaking change which adds functionality)

Reference: #4553

@kirankumarkolli
Copy link
Member

(will be available in bulk and batch operation
Bulk programmatically is internal implementation details should not be part of trace context

@sourabh1007 sourabh1007 marked this pull request as draft August 4, 2024 02:08
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/batchsizeinotel branch from 38e2a7d to 80340c6 Compare August 4, 2024 02:12
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/batchsizeinotel branch 4 times, most recently from 040c2f1 to 0093762 Compare August 5, 2024 11:15
@sourabh1007 sourabh1007 force-pushed the users/sourabhjain/batchsizeinotel branch from 0093762 to 1bdad8b Compare August 5, 2024 11:46
@sourabh1007 sourabh1007 marked this pull request as ready for review August 5, 2024 11:52
@sourabh1007 sourabh1007 added the auto-merge Enables automation to merge PRs label Aug 6, 2024
@sourabh1007 sourabh1007 self-assigned this Aug 6, 2024
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 9deb6e5 into master Aug 6, 2024
22 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/sourabhjain/batchsizeinotel branch August 6, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants