-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Request Hedging: Refactors HedgeRegion diagnostics field to only show successful region #4625
Merged
microsoft-github-policy-service
merged 17 commits into
master
from
users/nalutripician/hedgingDiagnosticsHedgeRegion
Aug 9, 2024
Merged
[Internal] Request Hedging: Refactors HedgeRegion diagnostics field to only show successful region #4625
microsoft-github-policy-service
merged 17 commits into
master
from
users/nalutripician/hedgingDiagnosticsHedgeRegion
Aug 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
August 2, 2024 18:58
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Show resolved
Hide resolved
NaluTripician
requested review from
khdang,
adityasa and
neildsh
as code owners
August 5, 2024 17:53
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
In Description: Exclude region is showing only after update |
Thinking loud: "Response Region" already covers which Task completed first. Update from offline:
|
Logs were from before remove exclude regions PR was merged. Updated to reflect current state. |
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
...t.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosAvailabilityStrategyTests.cs
Show resolved
Hide resolved
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Aug 9, 2024
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Show resolved
Hide resolved
ealsur
reviewed
Aug 9, 2024
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Aug 9, 2024
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Aug 9, 2024
...re.Cosmos/src/Routing/AvailabilityStrategy/CrossRegionParallelHedgingAvailabilityStrategy.cs
Outdated
Show resolved
Hide resolved
ealsur
approved these changes
Aug 9, 2024
kirankumarkolli
approved these changes
Aug 9, 2024
microsoft-github-policy-service
bot
deleted the
users/nalutripician/hedgingDiagnosticsHedgeRegion
branch
August 9, 2024 18:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Refactors Hedge Context. Hedge Context will show what regions the SDK reaches out to.
We are also replacing Hedge Regions with Response Region, showing what region the response is coming from.
Type of change
Please delete options that are not relevant.
Diagnostics Pre Change
Diagnostics Post Change