Fix Proxy Response Mapping #4630
Conversation
aavasthy
requested review from
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
| ref bytesDeserializer); | ||
|
|
||
| HttpResponseMessage response = new HttpResponseMessage((HttpStatusCode)storeResponse.StatusCode); | ||
| ref bytesDeserializer); |
There was a problem hiding this comment.
Will be adding more test coverage in parent branch. This change was supposed to be another commit in parent branch and not a separate PR, so closing this PR.
|
|
||
| HttpResponseMessage response = new HttpResponseMessage((HttpStatusCode)storeResponse.StatusCode) | ||
| { | ||
| RequestMessage = responseMessage.RequestMessage |
There was a problem hiding this comment.
Change is just including the RequrestMessage in response, right? Or am I missing something?
There was a problem hiding this comment.
Yes this change is to fix serializer during an error response from proxy. It was initially returing null reference exception due to incorrect request mapping. This change was supposed to be another commit in parent branch and not a separate PR, so closing this PR.
Pull Request Template
Description
This is a fix for the bug Fix Rntbd deserializer: Throwing exception when deserializing error responses
Type of change
Adding HttpResponse Request parameter mapping ProxyResponse.
Closing issues
To automatically close an issue: closes #4627