Query: Fixes prefetching to be disabled when MaxConcurrency is less than or equal to one #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neildsh
requested review from
khdang,
sboshra,
adityasa,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
neildsh
changed the title
kirankumarkolli
previously approved these changes
Aug 20, 2024
|
@neildsh can you please take a look at the failing query test? |
neildsh
force-pushed
the
users/ndeshpan/prefetchFix
branch
from
8eb0fcf
to
63a678a
Compare
neildsh
dismissed stale reviews from kirankumarkolli and FabianMeiswinkel
via
fd972da
neildsh
force-pushed
the
users/ndeshpan/prefetchFix
branch
from
0a71608
to
fd972da
Compare
kirankumarkolli
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables parallel prefetch when MaxConcurrency is less than or equal to one, since that would entail sequential fetches from the backend resulting in increased latency for no gain.
Type of change
Please delete options that are not relevant.