Open Telemetry : Adds query text in attribute #4664
+310
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
sourabh1007
force-pushed
the
users/sourabhjain/addqueryTextinOtel
branch
3 times, most recently
from
2f7c8e7
to
e663af5
Compare
sourabh1007
force-pushed
the
users/sourabhjain/addqueryTextinOtel
branch
from
816b162
to
8e29f00
Compare
jcocchi
reviewed
Sep 17, 2024
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryCoreRecorder.cs
Show resolved
Hide resolved
| showQueryMode = queryRequestOptions.ShowQueryMode.Value; | ||
|
|
||
| } | ||
| else if (requestOptions is ChangeFeedRequestOptions changeFeedRequestOptions && changeFeedRequestOptions.ShowQueryMode.HasValue) |
There was a problem hiding this comment.
Do we need to show query text for change feed operations?
There was a problem hiding this comment.
There is an option to pass query in change feed iterator. We can discuss and understand, if we really need it.
There was a problem hiding this comment.
What scenario would change feed expose a query in traces and when would it not? Do you have examples?
sourabh1007
force-pushed
the
users/sourabhjain/addqueryTextinOtel
branch
from
9b3858e
to
35201c3
Compare
joegoldman2
reviewed
Sep 20, 2024
| /// <summary> | ||
| /// Defines whether to print query in tracing attributes | ||
| /// </summary> | ||
| public enum ShowQueryMode |
There was a problem hiding this comment.
Should the values be in pascal case instead? It seems this is the convention in this repo like:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
db.query.textattribute to record queries in Traces.ShowQueryMode, which will have valid values asa)
NONE:Do not show query.b)
PARAMETERIZED_ONLY: Print parameterized query only.b)
ALLCosmosClientTelemetryOptionsandRequestOptions(i.e.QueryRequestOptionsandChangeFeedRequestOptions)Type of change