Trigger Failover On 3092 And 1022 #4670
Conversation
kundadebdatta
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
| @@ -133,6 +163,8 @@ private object GetExceptionMessage(Exception exception) | |||
| /// <param name="request">The request being sent to the service.</param> | |||
| public void OnBeforeSendRequest(DocumentServiceRequest request) | |||
| { | |||
| this.isMultiMasterWriteRegion = !request.IsReadOnlyRequest | |||
There was a problem hiding this comment.
I think you are missing the condition that >1 write region need to be available (honoring preferred regions, excludedRegions etc.) - Could be included in GlobalEndpointManager.CanUseMultipleriteRegion but glancing at the code I did not see this check.
| @@ -428,6 +445,13 @@ private static bool IsPartitionKeyRangeGone(TResponse response, Exception except | |||
| || (response?.StatusCode == HttpStatusCode.Gone && response?.SubStatusCode == SubStatusCodes.PartitionKeyRangeGone); | |||
| } | |||
|
|
|||
| private static bool IsGoneWithLeaseNotFound(TResponse response, Exception exception) | |||
| { | |||
| return exception is LeaseLostException | |||
There was a problem hiding this comment.
No LeaseLostException has completely different meaning - that is thrown when Change Feed Processor is losing the CFP lease.
There was a problem hiding this comment.
Yes, this is taken care in the original msdata PR: 1453704
There was a problem hiding this comment.
I have created a new exception type: LeaseNotFoundException. That PR has more context on it. We can follow up on that PR itself!
|
Was a demo PR. Closing since the original ones got merged. |
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber