Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hedging: Fixes Typo (WithAvailibilityStrategy -> WithAvailabilityStrategy) in CosmosClientBuilder #4684

Conversation

NaluTripician
Copy link
Contributor

@NaluTripician NaluTripician commented Sep 13, 2024

Pull Request Template

Description

CosmosClientBuilder.WithAvailibilityStrategy contains a typo in the word availability and it is inconsistent with AvailabilityStrategy.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #4668

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@NaluTripician NaluTripician changed the title [Internal] Hedging: Fixed Typo [Internal] Hedging: Fixes Typo Sep 13, 2024
Copy link
Contributor

@philipthomas-MSFT philipthomas-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But run UpdateContracts

@kirankumarkolli
Copy link
Member

kirankumarkolli commented Sep 13, 2024

Why is it marked internal? (Its fine lets cover it part of release notes
Pleas update tile with more context (not just typo)

@NaluTripician NaluTripician changed the title [Internal] Hedging: Fixes Typo Hedging: Fixes Typo in CosmosClientBuilder Sep 13, 2024
@NaluTripician NaluTripician self-assigned this Sep 13, 2024
@NaluTripician NaluTripician added the auto-merge Enables automation to merge PRs label Sep 13, 2024
@kirankumarkolli kirankumarkolli changed the title Hedging: Fixes Typo in CosmosClientBuilder Hedging: Fixes Typo (WithAvailibilityStrategy -> WithAvailabilityStrategy) in CosmosClientBuilder Sep 13, 2024
Copy link
Contributor

@philipthomas-MSFT philipthomas-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit b757f8c into master Sep 13, 2024
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/nalutripician/WithAvailabilityStrategyTypo branch September 13, 2024 18:40
NaluTripician added a commit that referenced this pull request Sep 18, 2024
…tegy) in CosmosClientBuilder (#4684)

* Update CosmosClientBuilder.cs

fixed typo

* Update DotNetPreviewSDKAPI.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in the new hedging API - WithAvailibilityStrategy
3 participants