Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client encryption]: Refactor EncryptionProcessor #4757

Conversation

JanHyka
Copy link
Contributor

@JanHyka JanHyka commented Oct 7, 2024

Pull Request Template

Description

Refactor EncryptionProcessor - split code paths for deprecated local implementation of Aes, split individual transformers to improve maintainability and testability, split preview/stable

To be processed after #4753

Type of change

Please delete options that are not relevant.

  • [] New feature (non-breaking change which adds functionality)

Closing issues

Contributes to #4678

juraj-blazek and others added 30 commits September 12, 2024 13:41
~ reduce validations overhead
~ update api file
kirankumarkolli
kirankumarkolli previously approved these changes Oct 8, 2024
@kirankumarkolli
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kirankumarkolli
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kirankumarkolli
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kirankumarkolli
Copy link
Member

Build failure, @JanHyka can you please take a look?

dotnet build Microsoft.Azure.Cosmos.sln -p:Optimize=true -p:IsPreview=true;SdkProjectRef=true

@kirankumarkolli
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kirankumarkolli
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kirankumarkolli kirankumarkolli merged commit ac78e58 into Azure:master Oct 9, 2024
23 checks passed
@JanHyka JanHyka deleted the users/jan-hyka/refactor-encryption-processor branch October 9, 2024 20:00
kirankumarkolli pushed a commit that referenced this pull request Oct 9, 2024
# Pull Request Template

## Description

- This is preliminary step to enable Brotli compression on
Cosmos.Encryption.Custom.
- .NET8.0 target was added to the project
- New compiler complaints were addressed

To be processed after #4757 

## Type of change

Please delete options that are not relevant.

- [] New feature (non-breaking change which adds functionality)

## Closing issues

Contributes to #4678

---------

Co-authored-by: Juraj Blazek <[email protected]>
Co-authored-by: juraj-blazek <[email protected]>
Co-authored-by: Santosh Kulkarni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants