Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Telemetry Traces: Fixes filtering of event on 404/0 or similar non failure status codes #4762

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

sourabh1007
Copy link
Contributor

Description

Added a check on Cosmos Exception to make sure events are generated only for the allowed status and substatuscode

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #4735

…nly for the allowed status and substatuscode
Copy link
Contributor

@philipthomas-MSFT philipthomas-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although more context on this is encouraged.

@kirankumarkolli kirankumarkolli merged commit 757b004 into master Oct 8, 2024
24 checks passed
@kirankumarkolli kirankumarkolli deleted the users/sourabhjain/oteltracesexception branch October 8, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Event Source writes on 404/0
3 participants