[Internal] Query: Removes unneeded check on supported query features #4868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles the HybridSearchQueryTests SanityTests. It also removes an unneeded (and problematic) check for unsupported features, which is not needed by the SDK.
sc978345
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sc978345
changed the title
adityasa
reviewed
Nov 5, 2024
...soft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/HybridSearchQueryTests.cs
Outdated
Show resolved
Hide resolved
adityasa
reviewed
Nov 5, 2024
...soft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/HybridSearchQueryTests.cs
Show resolved
Hide resolved
adityasa
reviewed
Nov 5, 2024
leminh98
previously approved these changes
Nov 5, 2024
sc978345
changed the title
neildsh
reviewed
Nov 5, 2024
...soft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/HybridSearchQueryTests.cs
Outdated
Show resolved
Hide resolved
neildsh
reviewed
Nov 5, 2024
...soft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/HybridSearchQueryTests.cs
Outdated
Show resolved
Hide resolved
neildsh
approved these changes
Nov 5, 2024
leminh98
approved these changes
Nov 5, 2024
neildsh
approved these changes
Nov 5, 2024
microsoft-github-policy-service
bot
deleted the
users/shauncooper/enable-hybridsearch-tests
branch
kundadebdatta
pushed a commit
that referenced
this pull request
Nov 10, 2024
…4868) This PR -Upgrades to the 3.37.1 version of the direct package -Adds additional testing on ORDER BY RANK RRF with VectorDistance in HybridSearchQueryTests SanityTests -Removes an unneeded (and problematic) check for unsupported features, which is not needed by the SDK. Previously, this code assumed there would always be a queryInfo object, however with hybrid search, this may not always be the case. But in addition, this check was not needed, so it is removed. Please delete options that are not relevant. - [] Bug fix (non-breaking change which fixes an issue)
kundadebdatta
pushed a commit
that referenced
this pull request
Nov 11, 2024
…4868) This PR -Upgrades to the 3.37.1 version of the direct package -Adds additional testing on ORDER BY RANK RRF with VectorDistance in HybridSearchQueryTests SanityTests -Removes an unneeded (and problematic) check for unsupported features, which is not needed by the SDK. Previously, this code assumed there would always be a queryInfo object, however with hybrid search, this may not always be the case. But in addition, this check was not needed, so it is removed. Please delete options that are not relevant. - [] Bug fix (non-breaking change which fixes an issue) Co-Authored-By: Kiran Kumar Kolli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
-Upgrades to the 3.37.1 version of the direct package
-Adds additional testing on ORDER BY RANK RRF with VectorDistance in HybridSearchQueryTests SanityTests
-Removes an unneeded (and problematic) check for unsupported features, which is not needed by the SDK. Previously, this code assumed there would always be a queryInfo object, however with hybrid search, this may not always be the case. But in addition, this check was not needed, so it is removed.
Type of change
Please delete options that are not relevant.