[INTERNAL] Emulator: Fixes upgrades to internal emulator #4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirankumarkolli
requested review from
FabianMeiswinkel,
sboshra and
Pilchie
as code owners
kirankumarkolli
requested review from
khdang,
adityasa,
neildsh and
kirillg
as code owners
kirankumarkolli
changed the title
kirankumarkolli
commented
Nov 9, 2024
kirankumarkolli
commented
Nov 9, 2024
kirankumarkolli
changed the title
kirankumarkolli
changed the title
sc978345
approved these changes
Nov 10, 2024
kundadebdatta
pushed a commit
that referenced
this pull request
Nov 11, 2024
Emulator: Fixes upgrades to internal emulator Observations: - FFCF/AVAD: Emulator defaults resulting in 400/back request => Unblocking with `enablePreviousImageForDeleteInFFCF` override - ReadFeed with Binary now service returning in binary format (related tests upated) - Misc escaping changes - Emulator: Startup times seems regressed (will follow-up later) On FFCF part: There are two tests Updates -> Drains changes -> Deletes -> ChangeFeed => 400 Update + Deletes -> Changefeed -> Succeeded with 200 but no previous image Included `includeIdAndPKForDeletesInFFCFResponse` override working for both scenarios.
kundadebdatta
pushed a commit
that referenced
this pull request
Nov 11, 2024
Emulator: Fixes upgrades to internal emulator Observations: - FFCF/AVAD: Emulator defaults resulting in 400/back request => Unblocking with `enablePreviousImageForDeleteInFFCF` override - ReadFeed with Binary now service returning in binary format (related tests upated) - Misc escaping changes - Emulator: Startup times seems regressed (will follow-up later) On FFCF part: There are two tests Updates -> Drains changes -> Deletes -> ChangeFeed => 400 Update + Deletes -> Changefeed -> Succeeded with 200 but no previous image Included `includeIdAndPKForDeletesInFFCFResponse` override working for both scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emulator: Fixes upgrades to internal emulator
Observations:
enablePreviousImageForDeleteInFFCFoverrideOn FFCF part: There are two tests
Updates -> Drains changes -> Deletes -> ChangeFeed => 400
Update + Deletes -> Changefeed -> Succeeded with 200 but no previous image
Included
includeIdAndPKForDeletesInFFCFResponseoverride working for both scenarios.