Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of Terraform modules for App Service - Enable free plan #1496

Merged
merged 6 commits into from
Mar 28, 2023

Conversation

lechnerc77
Copy link
Contributor

Content

This PR contains the changes necessary for a user to use the Azure App Service with a free plan. This plan is special as it comes with limitation concerning some settings, namely the always_on and the support of 64 bit workers.
The PR therefore exposes these configurations as variables and propagates the variables to the core modules.

The Terraform variables are defaulted and consequently optional. They contain the default values of the current setup. Introduction of the variables is therefore not a breaking change.

Reason

This setup might be useful for azd templates that serve as quickstarter or for demos/lessons at schools/universities to keep the cost of the setup at a minimum.

Additional information

The .bicep modules already contain the necessary parameters. So this PR synchronizes the options available for the supported IaC variants.

@ghost ghost added the customer-reported identify a customer issue label Feb 5, 2023
@ghost
Copy link

ghost commented Feb 5, 2023

Thank you for your contribution lechnerc77! We will review the pull request and get back to you soon.

@vhvb1989
Copy link
Member

vhvb1989 commented Feb 6, 2023

related: #1460

@jongio
Copy link
Member

jongio commented Feb 6, 2023

Should we default to free?

@lechnerc77
Copy link
Contributor Author

Should we default to free?

From what I have seen in our quickstarter repository, I would stick to the plan B1 for the azd templates, as the experience is better (due to the always_on setting). As with this PR you can reconfigure things for the free and shared plans I think this is okay.

@jongio
Copy link
Member

jongio commented Feb 7, 2023

Can we do the same for bicep templates?

@lechnerc77
Copy link
Contributor Author

@jongio The bicep template was already in perfect shape for adding the free plan. No adoptions needed there.

@weikanglim
Copy link
Contributor

/azp run azure-dev repoman

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@vhvb1989
Copy link
Member

/azp run azure-dev - template - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vhvb1989
Copy link
Member

vhvb1989 commented Mar 21, 2023

@lechnerc77 , please see the error messages from Terraform:

╷
│ Error: Unclosed configuration block
│ 
│ On modules/appservicepython/appservicepython_variables.tf line 59: There is
│ no closing brace for this block before the end of the file. This may be
│ caused by incorrect brace nesting elsewhere in this file.
╵

ERROR: planning deployment: planning infrastructure provisioning: terraform init failed:  , err: failed running terraform init:  (exit status 1)

### ERROR: Dev container exec failed (exit code: 1)

@vhvb1989
Copy link
Member

Trying closing missing bracket as simple fix

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lechnerc77
Copy link
Contributor Author

Trying closing missing bracket as simple fix

Seems to have worked, right? Sorry for that glitch!

@vhvb1989
Copy link
Member

blocked by: #1764

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: todo-nodejs-mongo-terraform

Remote: azure-samples-staging

Branch: pr/1496

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/1496

View Changes | Compare Changes


Project: todo-python-mongo-terraform

Remote: azure-samples-staging

Branch: pr/1496

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/1496

View Changes | Compare Changes


@vhvb1989 vhvb1989 merged commit 2dfac90 into Azure:main Mar 28, 2023
@lechnerc77 lechnerc77 deleted the feat/support-free-plan-tf branch September 15, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported identify a customer issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants