-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement of Terraform modules for App Service - Enable free plan #1496
Conversation
Thank you for your contribution lechnerc77! We will review the pull request and get back to you soon. |
related: #1460 |
Should we default to free? |
From what I have seen in our quickstarter repository, I would stick to the plan |
Can we do the same for bicep templates? |
@jongio The bicep template was already in perfect shape for adding the free plan. No adoptions needed there. |
/azp run azure-dev repoman |
No pipelines are associated with this pull request. |
/azp run azure-dev - template - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
@lechnerc77 , please see the error messages from Terraform:
|
Trying closing missing bracket as simple fix |
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
Seems to have worked, right? Sorry for that glitch! |
blocked by: #1764 |
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-nodejs-mongo-terraformRemote: azure-samples-stagingBranch: pr/1496You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/1496 View Changes | Compare Changes Project: todo-python-mongo-terraformRemote: azure-samples-stagingBranch: pr/1496You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/1496 View Changes | Compare Changes |
Content
This PR contains the changes necessary for a user to use the Azure App Service with a free plan. This plan is special as it comes with limitation concerning some settings, namely the
always_on
and the support of 64 bit workers.The PR therefore exposes these configurations as variables and propagates the variables to the core modules.
The Terraform variables are defaulted and consequently optional. They contain the default values of the current setup. Introduction of the variables is therefore not a breaking change.
Reason
This setup might be useful for
azd
templates that serve as quickstarter or for demos/lessons at schools/universities to keep the cost of the setup at a minimum.Additional information
The
.bicep
modules already contain the necessary parameters. So this PR synchronizes the options available for the supported IaC variants.