pkg/templates: Use *policy.ClientOptions
#4198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellismg
requested review from
wbreza,
vhvb1989,
hemarina and
weikanglim
as code owners
ellismg
force-pushed
the
ellismg/use-injected-client-options
branch
from
c5b1360
to
28f3c9c
Compare
vhvb1989
approved these changes
Aug 9, 2024
wbreza
approved these changes
Aug 19, 2024
Instead of taking a `httputil.HttpClient` (which at runtime is just an `*http.Client`) and forming a `*policy.ClientOptions` ourselves, let's just take in a `*policy.ClientOptions` as an Azure SDK client would. Functionaly the change here means these calls will start using our centralized `*policy.ClientOptions` which includes this like adding tracing headers and a user-agent header for the REST calls we make, just like any client from the Azure SDKs.
ellismg
force-pushed
the
ellismg/use-injected-client-options
branch
from
28f3c9c
to
6f23714
Compare
|
Doing this leads to some weird issues in an end to end test, I assume because more initialization code ends up running "earlier" in the process than we intended (via our IoC resolvers, I assume). I'm going to close this for now until I have some time to dig in and better understand what is causing this difference. |
auto-merge was automatically disabled
October 14, 2024 17:23
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of taking a
httputil.HttpClient(which at runtime is just an*http.Client) and forming a*policy.ClientOptionsourselves, let's just take in a*policy.ClientOptionsas an Azure SDK client would. Functionaly the change here means these calls will start using our centralized*policy.ClientOptionswhich includes this like adding tracing headers and a user-agent header for the REST calls we make, just like any client from the Azure SDKs.