WIP: provisioning: Consider resourceGroup from azure.yaml
#4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow specifying the resource group which is used for discovery of resources (instead of probing for a resource group taged with `azd-env-name` inside `azure.yaml`. When doing a resource group scoped deployment, we should consider this value if set and use it instead of prompting the user to select a resource group or create a new one. Fixes Azure#4287
ellismg
commented
Sep 13, 2024
| @@ -52,10 +54,9 @@ type StateResult struct { | |||
|
|
|||
| type Provider interface { | |||
| Name() string | |||
| Initialize(ctx context.Context, projectPath string, options Options) error | |||
| Initialize(ctx context.Context, projectPath string, options Options, rg osutil.ExpandableString) error | |||
There was a problem hiding this comment.
I initially considered trying to have Initialize take the entire project.ProjectConfig object so it could grab this property, but that doesn't work because it creates an import cycle between the project and provisioning packages.
Sort of a bummer that the resourceGroup property doesn't hang off of the provisioning.Options type. It probably would have made more sense to nest that under infra vs it being a top level property.
ellismg
commented
Sep 13, 2024
| ctx context.Context, | ||
| projectPath string, | ||
| options provisioning.Options, | ||
| _ osutil.ExpandableString, |
There was a problem hiding this comment.
Wondering what if anything we should do here for Terraform, perhaps we should be adding this to envVars with something like AZURE_RESOURCE_GROUP so tf could observe it?
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
ellismg
commented
Sep 16, 2024
| // | ||
| // We also need to understand the policy of what happens if both are set - which one wins? I think that perhaps | ||
| // it should be `AZURE_RESOURCE_GROUP` since that also allows overriding via `AZURE_RESOURCE_GROUP=foo azd up`. | ||
| p.env.DotenvSet(environment.ResourceGroupEnvVarName, rgEval) |
There was a problem hiding this comment.
This is pretty gross, IMHO, but the rest of the system right now reads environment.ResourceGroupEnvVarName from the .env to find the resource group to use. I suspect that I need to do a deeper refactoring such that we can consider both what is in the azure.yaml file and what is in the .env but right now doing things this way lets the rest of the system work.
But there are open questions, hence the big TODO and the draft nature of this PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow specifying the resource group which is used for discovery of resources (instead of probing for a resource group taged with
azd-env-nameinsideazure.yaml. When doing a resource group scoped deployment, we should consider this value if set and use it instead of prompting the user to select a resource group or create a new one.Fixes #4287