Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 2) #1020

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 2) #1020

wants to merge 1 commit into from

Conversation

meganbradley
Copy link
Contributor

Applying sensitive terms with GUID changes as part of Content SFI and outlined in Overview - Writing content securely - Platform Manual. Changes are part of the Microsoft-wide SFI effort. Point of contact: @CelesteDG

DocuTune v1.5.2.0
CorrelationId: ac15aa43-4e2b-437f-ab1c-fdd7e79cd4db

#docutune

@meganbradley
Copy link
Contributor Author

#docutune-review

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit f337d47:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
azureadps-2.0/AzureAD/migrate/New-AzureADUser.md ❌Error Details

azureadps-2.0/AzureAD/migrate/New-AzureADUser.md

  • Line 28, Column 1: [Error: include-not-found - See documentation] Invalid include link: '~/graphref/api-reference/v1.0/includes/permissions/user-post-users-permissions.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@CelesteDG CelesteDG closed this Oct 18, 2024
@CelesteDG CelesteDG reopened this Oct 18, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit f337d47:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
azureadps-2.0/AzureAD/migrate/New-AzureADUser.md ❌Error Details

azureadps-2.0/AzureAD/migrate/New-AzureADUser.md

  • Line 28, Column 1: [Error: include-not-found - See documentation] Invalid include link: '~/graphref/api-reference/v1.0/includes/permissions/user-post-users-permissions.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@msewaweru msewaweru closed this Oct 22, 2024
@msewaweru msewaweru reopened this Oct 22, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit f337d47:

✅ Validation status: passed

File Status Preview URL Details
azureadps-2.0-preview/AzureAD/Add-AzureADGroupOwner.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Add-AzureADGroupOwner.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Add-AzureADMSApplicationOwner.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Add-AzureADMSApplicationOwner.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Add-AzureADMSPrivilegedResource.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Add-AzureADMSPrivilegedResource.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Connect-AzureAD.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Connect-AzureAD.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADApplication.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADApplication.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationExtensionProperty.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationExtensionProperty.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationKeyCredential.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationKeyCredential.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationLogo.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationLogo.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationOwner.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationOwner.yml ✅Succeeded
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationPasswordCredential.md ✅Succeeded View (azureadps-2.0-preview)
azureadps-2.0-preview/AzureAD/Get-AzureADApplicationPasswordCredential.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

msewaweru
msewaweru requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@msewaweru msewaweru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions added.

azureadps-2.0-preview/AzureAD/Get-AzureADApplication.md
@@ -57,7 +57,7 @@ Output:

ObjectId AppId DisplayName
-------- ----- -----------
ed192e92-84d4-4baf-997d-1e190a81f28e 36ee4c6c-0812-40a2-b820-b22ebd02bce3 MyNewApp
00001111-aaaa-2222-bbbb-3333cccc4444 36ee4c6c-0812-40a2-b820-b22ebd02bce3 MyNewApp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppId value not updated.

azureadps-2.0-preview/AzureAD/Get-AzureADApplication.yml
@@ -27,7 +27,7 @@ examples:
summary: ""
- title: 'Example 2: Get an application by ID'
code: |-
PS C:\>Get-AzureADApplication -Filter "AppId eq 'ed192e92-84d4-4baf-997d-1e190a81f28e'"
PS C:\>Get-AzureADApplication -Filter "AppId eq '00001111-aaaa-2222-bbbb-3333cccc4444'"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GUIDs in the output haven't been updated.

azureadps-2.0-preview/AzureAD/Get-AzureADApplicationExtensionProperty.md
@@ -27,7 +27,7 @@ The **Get-AzureADApplicationExtensionProperty** cmdlet gets application extensio

### Example 1: Get extension properties
```
PS C:\>Get-AzureADApplicationExtensionProperty -ObjectId "3ddd22e7-a150-4bb3-b100-e410dea1cb84"
PS C:\>Get-AzureADApplicationExtensionProperty -ObjectId "aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output GUIDs haven't been updated.

azureadps-2.0-preview/AzureAD/Get-AzureADApplicationExtensionProperty.yml
@@ -16,7 +16,7 @@ syntaxes:
examples:
- title: 'Example 1: Get extension properties'
code: |-
PS C:\>Get-AzureADApplicationExtensionProperty -ObjectId "3ddd22e7-a150-4bb3-b100-e410dea1cb84"
PS C:\>Get-AzureADApplicationExtensionProperty -ObjectId "aaaaaaaa-0000-1111-2222-bbbbbbbbbbbb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output GUIDs haven't been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msewaweru msewaweru msewaweru requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meganbradley @msewaweru @CelesteDG