Upgrade storage client & support Entra identities for storage in more scenarios #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelij
requested review from
vrdmr,
Francisco-Gamino,
andystaples,
amamounelsayed,
ejizba,
hossam-nasr,
AnatoliB and
khkh-ms
as code owners
xanecs
reviewed
Feb 23, 2024
| { | ||
| var storageAccount = await ArmClient.FindStorageAccount(accountName); | ||
| blobContainerClient = new BlobContainerClient(new UriBuilder(storageAccount.Properties.PrimaryEndpoints.Blob) { Path = containerName }.Uri, | ||
| new Storage.StorageSharedKeyCredential(accountName, storageAccount.Key.Value)); |
There was a problem hiding this comment.
Remove the StorageSharedKeyCredential and use this.Credential instead.
This allows disabling Shared Keys on the storage account altogether.
|
|
||
| return blob.Uri + blobToken; | ||
| return blob.GenerateSasUri(sasConstraints).ToString(); |
There was a problem hiding this comment.
Again, to allow disabling Shared Keys on the storage account, return blob.Uri in case managed identity is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Resolves #3376
Pull request checklist
PR overview:
AzureCliCredentialandAzurePowerShellCredentialto fetch an access token instead of the code that calls the CLIsDefaultAzureCredentialto preserve the current behavior, as it might require the user to specify a tenant ID under certain conditionsAzureWebJobsStorage__accountNamein more scenarios: