Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When local.settings.json is absent, runnig func host start does not work for newer worker models #3544 #3836

Open
wants to merge 10 commits into
base: v4.x
Choose a base branch
from

Conversation

VineethReyya
Copy link
Contributor

@VineethReyya VineethReyya commented Sep 25, 2024

Issue describing the changes in this PR

-> when local.settings.json is absent.
Scenario1: running 'func host start' will Display Available WorkerRuntime on the screen and user can select the Runtime from the list so the FUNCTION_WORKER_RUNTIME setting is added and start hosting the function app
Scenario2: running 'func host start --{WorkerRuntime}' will add FUNCTION_WORKER_RUNTIME setting and start hosting the function app.

resolves #3544

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@sinedied
Copy link
Member

Thanks for working on this!
Could you also check if this approach works when the core tools are started by the Static Web Apps CLI?
I'm afraid the terminal might not be TTY in that case, and would then not allow user interactions.

SWA CLI is used in many of our samples along with the Functions emulators, so this would still remain an issue.

@VineethReyya
Copy link
Contributor Author

Thanks for working on this! Could you also check if this approach works when the core tools are started by the Static Web Apps CLI? I'm afraid the terminal might not be TTY in that case, and would then not allow user interactions.

SWA CLI is used in many of our samples along with the Functions emulators, so this would still remain an issue.

Thanks for the suggestion. will look into it

liliankasem
liliankasem previously approved these changes Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When local.settings.json is absent, runnig func host start does not work for newer worker models
4 participants