Skip to content

Updating startup failure logging. #11055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

RohitRanjanMS
Copy link
Member

@RohitRanjanMS RohitRanjanMS commented May 6, 2025

Enhancing the capability to send startup failure logs to AppInsights/Otel. If an error occurs during startup, the CompositeLogger will record the failure in AppInsights/Otel. Additionally, this feature will log the FAILED TO INITIALIZE RUN FROM PACKAGE.txt to AppInsights/Otel

resolves #11061

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@RohitRanjanMS RohitRanjanMS marked this pull request as ready for review May 6, 2025 06:34
@RohitRanjanMS RohitRanjanMS requested a review from a team as a code owner May 6, 2025 06:34
@jviau
Copy link
Contributor

jviau commented May 6, 2025

Can we get any tests for this? Or is there existing test coverage?

@RohitRanjanMS
Copy link
Member Author

There's no test coverage for failure. I will have to figure how can I add an InMemoryExporter to assert these logs.

@RohitRanjanMS RohitRanjanMS requested a review from kshyju May 13, 2025 22:53
@RohitRanjanMS RohitRanjanMS requested a review from kshyju May 15, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startup failure logging
3 participants