-
Notifications
You must be signed in to change notification settings - Fork 457
Adding support for collecting cross-platform perf traces and generating PGO JIT traces #11066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…ng PGO JIT traces.
Looking at specialization urls for Flex we do need a call to /admin/instance/assign as well to include in PGO. Here are all the calls to the Host during cold start and specialization: url Looks like we are doing 1 and 3 but not 2 |
I reviewed the code for the I'll handle that setup in a separate change to keep this PR focused and easier to review. It will also involve modifying the placeholder simulation logic — for example, this line needs to be removed, since the code only checks for the existence of the environment variable, not whether its value is "1". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable cross-platform performance trace collection and PGO JIT trace generation.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md