Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SDK bindings changes #1423

Merged
merged 160 commits into from
Apr 11, 2024
Merged

feat: SDK bindings changes #1423

merged 160 commits into from
Apr 11, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Feb 5, 2024

Description

  • allows new TypedData object of "model_binding_data"
  • imports base library & creates deferred bindings registry if needed
  • checks defined type to see if should assign ClientConverter or regular Converter
  • adds SupportsDeferredBinding flag to each supported binding through raw_bindings

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 22.85714% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 32.03%. Comparing base (c68f88b) to head (5e644ce).

Files Patch % Lines
azure_functions_worker/bindings/meta.py 24.13% 22 Missing ⚠️
azure_functions_worker/loader.py 25.00% 3 Missing ⚠️
azure_functions_worker/bindings/datumdef.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1423       +/-   ##
===========================================
- Coverage   85.10%   32.03%   -53.08%     
===========================================
  Files          35       35               
  Lines        1974     2001       +27     
  Branches      374      381        +7     
===========================================
- Hits         1680      641     -1039     
- Misses        218     1359     +1141     
+ Partials       76        1       -75     
Flag Coverage Δ
unittests 32.03% <22.85%> (-53.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vrdmr
vrdmr previously requested changes Apr 11, 2024
tests/utils/testutils.py Show resolved Hide resolved
azure_functions_worker/bindings/meta.py Outdated Show resolved Hide resolved
azure_functions_worker/bindings/meta.py Outdated Show resolved Hide resolved
azure_functions_worker/bindings/meta.py Outdated Show resolved Hide resolved
azure_functions_worker/bindings/meta.py Outdated Show resolved Hide resolved
azure_functions_worker/bindings/meta.py Show resolved Hide resolved
@hallvictoria hallvictoria dismissed stale reviews from gavin-aguiar and vrdmr April 11, 2024 20:27

Addressed

@YunchuWang YunchuWang self-requested a review April 11, 2024 22:16
azure_functions_worker/dispatcher.py Outdated Show resolved Hide resolved
azure_functions_worker/bindings/meta.py Show resolved Hide resolved
azure_functions_worker/dispatcher.py Outdated Show resolved Hide resolved
@hallvictoria hallvictoria merged commit 330783f into dev Apr 11, 2024
40 of 50 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/sdk-bindings branch April 11, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants