Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts for Application Gateway References, SQL Managed Instances and Sql Server Databases #88

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

sihbher
Copy link
Contributor

@sihbher sihbher commented Dec 7, 2023

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.
I added alerts for Application Gateway References, SQL Managed Instances and Sql Server Databases

This PR fixes/adds/changes/removes

  1. References added for Application Gateway
  2. Alerts added for SQL Managed Instances
  3. Alerts added for SQL Server Databases

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

JoeyBarnes
JoeyBarnes previously approved these changes Dec 8, 2023
@JoeyBarnes JoeyBarnes self-requested a review December 8, 2023 16:40
@JoeyBarnes JoeyBarnes dismissed their stale review December 8, 2023 16:41

I missed the linting errors in my first review

Copy link
Contributor

@JoeyBarnes JoeyBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the YAML linting errors. The warnings can be ignored for now.

https://github.com/Azure/azure-monitor-baseline-alerts/actions/runs/7134476286/job/19429380666?pr=88#step:4:95

@JoeyBarnes JoeyBarnes merged commit 761610d into Azure:main Dec 11, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants