-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/fcmv1 #311
base: main
Are you sure you want to change the base?
Feature/fcmv1 #311
Conversation
Created a set of tests around creating FCMv1 registrations and sending FCMv1 notifications. Also updated some common tests to use FCMv1 instead of FCM to future proof them a bit
@microsoft-github-policy-service agree |
hi - would it possible to know when this will be merged? |
It's been sitting with some open questions for a while. I can see @jessHuh is typically assigned to review some recent PRs. |
ok - is it a case of lack of time for @jessHuh to have a look at this and move it forward? |
Greatly appreciated if this could be reviewed |
this is just a joke now - Common what is the problem not even the bliming courtesy to say something |
@rextor92 looks good. No need for you to upload your test files. Go ahead and add the deprecation tags. Yes, package will be bumped to 4.2.1. After you push up your changes I will sign off on this PR. |
Hi - why does it take sooooo long to merge this one and push a new nuget??? It would help to know @lomagdal2 |
Any chance of this pull request being merged? Many thanks |
Description
I have added the newly created SendFcmV1NativeNotificationAsync methods to the INotificationHubClient so that we can continue mocking a client in projects after updating.
Also added some FCMv1 tests with the new payload structure for notifications.
Related PRs or issues
Fixes #307
Relates to #110
Misc
[Obsolete("SendFcmNativeNotificationAsync will be deprecated on July 1st, 2024. Please use SendFcmV1NativeNotificationAsync instead.")]
Things to consider before you submit the PR: