-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend web push support #320
base: main
Are you sure you want to change the base?
Extend web push support #320
Conversation
@microsoft-github-policy-service agree company="Hahn Softwareentwicklung GmbH" |
Can someone please review this PR? |
lgtm |
Hey lomagdal2, I'm nervously excited about you getting this one over the finish line. 😬😃 Do you have any idea when you will have the time to wrap this one up? Many, many thanks, Paul. |
Hey @lomagdal2 , any chance of a Friday treat? 🍦 |
😴🥺😩 @lomagdal2 |
😴🥺😩🧟♂️💀 @lomagdal2 |
FFS!!!! Press the flippin button 🤬 |
Pleeeeeeease aprove! |
Hello folks! Apologies for the late reply. We are currently working on enhancing our core security for ANH and have added this task into our backlog. We will keep you posted once we review and merge the code. Thanks for using ANH for your notification needs. |
The absolute glacial pace of such a core package being updated makes me question using Azure for my project. Microsoft's own cloud service doesn't have an updated SDK in their own language? Come on. |
Hi,
this adds some missing annotations for the recently added BrowserRegistrationDescriptions and registers them with the serializer. Besides that, I added some convenience methods to NotificationHubClient in accordance with the already existing ones.
Things to consider before you submit the PR:
Related PRs or issues
#314
Misc
"CreateBrowserTemplateRegistrationAsync" methods are currently not added it INotificationHubClient.