Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TrustedSigning] Add module TrustedSigning.Autorest #27167

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

VeryEarly
Copy link
Collaborator

@VeryEarly VeryEarly commented Feb 19, 2025

Description

Replacing #27162. The previous PR has some migrate issue, which caused the current situation where the PR Validation can not be triggered.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@VeryEarly VeryEarly changed the title [ENG] test add trusted codesigining [TrustedSigning] Add module TrustedSigning.Autorest Feb 19, 2025
@NoriZC
Copy link
Contributor

NoriZC commented Feb 19, 2025

@janielMartell
Could you please help fix the test issue below:

Describing Get-AzTrustedSigningAccount
[-] Get 275ms
ArgumentException: Missing Request 'Get-AzTrustedSigningAccount+[NoContext]+Get+$PUT+https://management.azure.com/subscriptions/76a1b60e-e087-45e5-be6e-8cdeeaee8e77/resourceGroups/azpssdktest/providers/Microsoft.CodeSigning/codeSigningAccounts/azpstestaccount?api-version=2024-09-30-preview+1' in recording file (Parameter 'rqKey')
at New-AzTrustedSigningAccount, D:\a_work\1\s\artifacts\Debug\Az.TrustedSigning\TrustedSigning.Autorest\exports\ProxyCmdletDefinitions.ps1: line 639
at , D:\a_work\1\s\artifacts\Debug\Az.TrustedSigning\TrustedSigning.Autorest\test\Get-AzTrustedSigningAccount.Tests.ps1: line 19
[-] List 28ms
ArgumentException: Missing Request 'Get-AzTrustedSigningAccount+[NoContext]+List+$PUT+https://management.azure.com/subscriptions/76a1b60e-e087-45e5-be6e-8cdeeaee8e77/resourceGroups/azpssdktest/providers/Microsoft.CodeSigning/codeSigningAccounts/azpstestaccount1?api-version=2024-09-30-preview+1' in recording file (Parameter 'rqKey')
at New-AzTrustedSigningAccount, D:\a_work\1\s\artifacts\Debug\Az.TrustedSigning\TrustedSigning.Autorest\exports\ProxyCmdletDefinitions.ps1: line 639
at , D:\a_work\1\s\artifacts\Debug\Az.TrustedSigning\TrustedSigning.Autorest\test\Get-AzTrustedSigningAccount.Tests.ps1: line 31

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@janielMartell
Copy link
Contributor

adressing the comments in this PR since I can't push directly to this branch. #27216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants