Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding xms-ids for Communication #17662

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Adding xms-ids for Communication #17662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
594bafb
Adding xms-ids for Communication
agalerrotaru Feb 2, 2022
ac59d9b
Merge branch 'Azure:main' into agalerrotaru/xms-ids-communication
agalerrotaru Feb 2, 2022
d44da47
adding note in readme
agalerrotaru Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ...urce-manager/Microsoft.Communication/preview/2020-08-20-preview/CommunicationService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,10 @@
"type": "array",
"items": {
"$ref": "#/definitions/Operation"
}
},
"x-ms-identifiers": [
"name"
]
},
"nextLink": {
"description": "The URL the client should use to fetch the next page (per server side paging).\r\nIt's null for now, added for future use.",
Expand Down Expand Up @@ -739,7 +742,11 @@
"type": "array",
"items": {
"$ref": "#/definitions/MetricSpecification"
}
},
"x-ms-identifiers": [
"name",
"category"
]
}
}
},
Expand Down Expand Up @@ -791,7 +798,10 @@
"type": "array",
"items": {
"$ref": "#/definitions/Dimension"
}
},
"x-ms-identifiers": [
"name"
]
}
}
},
Expand Down
5 changes: 5 additions & 0 deletions specification/communication/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,8 @@ See configuration in [readme.go.md](./readme.go.md)
## Typescript

See configuration in [readme.typescript.md](./readme.typescript.md)


## Comments and notes
x-ms-identifiers will become a requirement on every RP resource. To add it, [check here](https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers).
For more info, reach out to the @changeanalysisteam.