Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update JS configs for Jan release #32092

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 commented Jan 10, 2025

To update some tspconfig.yaml files for JS releases.

@kazrael2119 kazrael2119 requested a review from qiaozha as a code owner January 10, 2025 06:38
Copy link

openapi-pipeline-app bot commented Jan 10, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

Copy link

openapi-pipeline-app bot commented Jan 10, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/postgresql/armpostgresql There is no API change compared with the previous version
Go sdk/resourcemanager/postgresql/armpostgresqlflexibleservers There is no API change compared with the previous version
Go sdk/resourcemanager/workloadssapvirtualinstance/armworkloadssapvirtualinstance There is no API change compared with the previous version
Java azure-resourcemanager-computeschedule https://apiview.dev/Assemblies/Review/5097351b92ac4aa796623f11befc0711?revisionId=f3407d2b55334078be84c32b4bef7937
Java azure-resourcemanager-postgresqlflexibleserver https://apiview.dev/Assemblies/Review/21a61d731117447dbd7223467d7cfa42?revisionId=61f94591cbbb4b20a8a697402fc010c8
Java azure-resourcemanager-workloadssapvirtualinstance https://apiview.dev/Assemblies/Review/37dd904b3d2645f88d4d767d916757c2?revisionId=6138286290a24362a3f02568cabac41b
.Net Azure.ResourceManager.ComputeSchedule There is no API change compared with the previous version
.Net Azure.ResourceManager.PineconeVectorDB https://apiview.dev/Assemblies/Review/992deaa21f63472abc4083d85a46cd90?revisionId=8074b5b5ddab44ae83230089aae52330
.Net Azure.ResourceManager.PostgreSql There is no API change compared with the previous version
JavaScript @azure/arm-computeschedule https://apiview.dev/Assemblies/Review/4c90a15f611446ecb8a2654f22852f38?revisionId=8011dee3ef624f2aa035640afb37c0d3
JavaScript @azure/arm-pineconevectordb https://apiview.dev/Assemblies/Review/9e62bf21a58a4e1dbe5a13f8bf8a7e98?revisionId=5f9066ab598249dbb9fd795aed99a675
JavaScript @azure/arm-workloadssapvirtualinstance https://apiview.dev/Assemblies/Review/7e44ad83bb8b4da8919dfdd64022f85a?revisionId=2e19f37458524ef887ff676677765870
Python azure-mgmt-computeschedule https://apiview.dev/Assemblies/Review/014ca20ab0e54bcd8fc128970bb46740?revisionId=ec5b30fa336946089890c0593f07ff58
Python azure-mgmt-pineconevectordb https://apiview.dev/Assemblies/Review/2dd040a25f0c417aba2139ba9a79888f?revisionId=789953c8829b4931a5ad681103d5ab46
Python azure-mgmt-postgresqlflexibleservers https://apiview.dev/Assemblies/Review/2f26588813fb482db3523970145d3eb0?revisionId=1a6c172b23fb4c568e7a127a80d01b77
Python azure-mgmt-workloadssapvirtualinstance https://apiview.dev/Assemblies/Review/2f843ceb74d5460983cf919d11b44bfd?revisionId=a5c96989946a4e7993ce224d47e37f67

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 10, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ComputeSchedule
Pinecone.VectorDb

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 10, 2025
This was referenced Jan 10, 2025
@razvanbadea-msft
Copy link
Contributor

fix the SpellCheck check

@razvanbadea-msft razvanbadea-msft added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 10, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 10, 2025
@qiaozha qiaozha added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required PublishToCustomers Acknowledgement the changes will be published to Azure customers. and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMReview labels Jan 16, 2025
@qiaozha
Copy link
Member

qiaozha commented Jan 16, 2025

I don't think we need arm review for JS codegen related configuration change. @razvanbadea-msft let me know if you have any concerns.

@qiaozha
Copy link
Member

qiaozha commented Jan 16, 2025

it shouldn't have any change that will impact Go SDK generation. /cc @tadelesh

@qiaozha qiaozha enabled auto-merge (squash) January 16, 2025 04:49
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 16, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 17, 2025
@qiaozha qiaozha added BreakingChange-Python-Sdk-Approved and removed ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 17, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants