You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tables' ci.yml was the only one that was inconsistent. All other instances within the repo have the LiveTestCtestRegex value match CtestRegex, so we fixed it in #6223, for consistency.
We should consider picking a viable format, and apply it consistently, to avoid confusion.
A strawman proposal is to have it be unquoted, without the wild card, matching what we have in our template and core project: azure-template azure-core azure-security-keyvault azure-storage
Open question:
Would it make a difference to the set of tests that get matched/run if the regex value ended with a period . or not?
The text was updated successfully, but these errors were encountered:
ahsonkhan
added
EngSys
This issue is impacting the engineering system.
MQ
This issue is part of a "milestone of quality" initiative.
labels
Nov 15, 2024
* is a special character in YAML so if used in a string the string should be wrapped in quotes
We use --tests-regex which only requires a match of the name to the regex (not a match of the entire name)
Two things to consider:
You can probably remove the .* from the regexes and not change the tests that run. Which means you can also remove the quotes.
If tests that depend on live services don't require special regexes and filtering you can probably consolidate everything into a single CtestRegex instead of having both CtestRegex and LiveTestCtestRegex .. This means that live tests should be able to (if they aren't already) run properly in the absence of live services (e.g. playback of recordings) or know when to skip
Tables' ci.yml was the only one that was inconsistent. All other instances within the repo have the
LiveTestCtestRegex
value matchCtestRegex
, so we fixed it in #6223, for consistency.That said, some use wild-card (
*
), while others have it wrapped in quotes (""
), while the rest leave it as plain-text:https://github.com/search?q=repo%3AAzure%2Fazure-sdk-for-cpp%20LiveTestCtestRegex&type=code
We should consider picking a viable format, and apply it consistently, to avoid confusion.
A strawman proposal is to have it be unquoted, without the wild card, matching what we have in our template and core project:
azure-template
azure-core
azure-security-keyvault
azure-storage
Open question:
Would it make a difference to the set of tests that get matched/run if the regex value ended with a period
.
or not?azure-sdk-for-cpp/sdk/template/ci.yml
Line 29 in 384552a
azure-sdk-for-cpp/sdk/keyvault/ci.yml
Lines 30 to 31 in 384552a
azure-sdk-for-cpp/sdk/storage/ci.yml
Lines 30 to 33 in 384552a
The text was updated successfully, but these errors were encountered: