-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LiveTestCtestRegex within the ci.yml to match the CtestRegex value set #6223
base: main
Are you sure you want to change the base?
Conversation
/azp run cpp - tables |
Azure Pipelines successfully started running 1 pipeline(s). |
FWIW, in yaml, all text elements are treated as strings whether they are quoted or not. The only time you NEED to quote text in yaml is if you need to include special characters in the string (like " or '). But fundamentally, they are both syntactically correct yaml. I personally wouldn't stress over the quoting issue in yaml. Also, the regex format in ctest is described here. The reason you don't need to append |
CtestRegex: azure-data-tables.* | ||
LineCoverageTarget: 77 | ||
BranchCoverageTarget: 42 | ||
LiveTestCtestRegex: azure-data-tables | ||
LiveTestCtestRegex: azure-data-tables.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if it works without .*
, I like that lines 30 and 33 are the same now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% agreed with Anton.
Before:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4332699&view=logs&j=b480f431-cfd9-5d07-f486-b73452ab58e9&t=17eb15d2-6ebc-5155-18b3-76202a687fa3
(no tests skipped)
After:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4335700&view=logs&j=b480f431-cfd9-5d07-f486-b73452ab58e9&t=1e63cd11-2fcd-5751-b03e-76d95e2e6189
(no tests skipped)
Conclusion: Explicitly specifying the wild-card isn't necessary here. The regex is already picking up on all the tests that start with
azure-data-tables
.All other instances within the repo have the
LiveTestCtestRegex
value matchCtestRegex
, so we could consider cleaning that up, for consistency.Follow-up consistency issue across the repo: #6224
Some use wild-card (
*
), while others have it wrapped in quotes (""
), while the rest leave it as plain-text:https://github.com/search?q=repo%3AAzure%2Fazure-sdk-for-cpp%20LiveTestCtestRegex&type=code
azure-sdk-for-cpp/sdk/keyvault/ci.yml
Lines 30 to 31 in 384552a
azure-sdk-for-cpp/sdk/storage/ci.yml
Lines 30 to 33 in 384552a