Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change design of InputStream timeout in JDK HttpClient #41090

Merged

Conversation

alzimmermsft
Copy link
Member

Description

Changes the design of the timeout-based InputStream to wrap the InputStream returned by the built-in JDK HttpClient BodyHandlers instead of a custom implementation that converts the Flow to an InputStream. This is being done as it has been seen that some scenarios are deadlocking within the conversion layer and this investigates, a likely less performant but simpler, solution of wrapping the InputStream read calls with a timeout.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft alzimmermsft merged commit d85c199 into Azure:main Jul 24, 2024
18 of 20 checks passed
@alzimmermsft alzimmermsft deleted the AzJdkHttp_StabilizeInputStreamTimeout branch July 24, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants