Change design of InputStream timeout in JDK HttpClient #41090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the design of the timeout-based
InputStream
to wrap theInputStream
returned by the built-in JDK HttpClientBodyHandlers
instead of a custom implementation that converts theFlow
to anInputStream
. This is being done as it has been seen that some scenarios are deadlocking within the conversion layer and this investigates, a likely less performant but simpler, solution of wrapping theInputStream
read calls with a timeout.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines