Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, migrate some premium libs to sss #41402

Merged
merged 19 commits into from
Aug 2, 2024
Merged

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Aug 2, 2024

Description

  • part of azure-json, migrate existing premium MGMT libs #41194
  • api-specs.json change in be18d6d and appplatform(forgot to cherry-pick this one): 694a943
  • manual code in f1f9361
  • changelog: 01a8b7e
  • migrated libs that aren't much affected by the migration, manual code is almost all module-info.java
    • storage
    • keyvault
    • authorization(msgraph)
    • msi
    • containerregistry
    • containerservice
    • containerinstance
    • appplatform
    • dns
    • privatedns
    • eventhubs
    • trafficmanager
    • search
  • one commit for each regen
  • bumped autorest.java version: 8270466

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

keyvault config

authorization config

msi config

containerregistry config

containerservice config

containerinstance

dns config

privatedns config

eventhubs config

trafficmanager config

search config
manual code

manual code

manual code

manual code

manual code

manual code

manual code

manual code

manual code

manual code

manual code

manual code
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Aug 2, 2024
@weidongxu-microsoft
Copy link
Member

appservice may have a break upon regen (they've changed a float to int).

no problem if this does not show up.

@XiaofeiCao
Copy link
Contributor Author

appservice may have a break upon regen (they've changed a float to int).

no problem if this does not show up.

OK. I found no breaks last time I regened, probably before their fix.

I'll regen again to include this fix.

@weidongxu-microsoft
Copy link
Member

appservice may have a break upon regen (they've changed a float to int).
no problem if this does not show up.

OK. I found no breaks last time I regened, probably before their fix.

I'll regen again to include this fix.

Don't. Just keep it as this.

We'd better to take in the break in a separate PR.

@XiaofeiCao XiaofeiCao merged commit 16bf2b7 into Azure:main Aug 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants