Migrate Identity Live tests deployment to Fed Auth. #42635
Draft
+30
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g2vinay
changed the title
…to update-identity-live-tests
g2vinay
force-pushed
the
update-identity-live-tests
branch
from
c8f73e7
to
3cd1232
Compare
weshaggard
reviewed
Oct 28, 2024
sdk/identity/ci.yml
Outdated
| EnvVars: | ||
| SYSTEM_ACCESSTOKEN: $(System.AccessToken) | ||
| ARM_OIDC_TOKEN: $(ARM_OIDC_TOKEN) |
There was a problem hiding this comment.
In order to get these variables I think you will need to plumb the PersistOidcToken token open similar to what @benbp is doing in js at Azure/azure-sdk-for-js#31335
There was a problem hiding this comment.
Yep, and we should revert usage of ARM_CLIENT_ID and ARM_TENANT_ID, since these variables are already set as IDENTITY_*_ID
weshaggard
reviewed
Oct 28, 2024
sdk/identity/ci.yml
Outdated
| ARM_CLIENT_ID: $(ARM_CLIENT_ID) | ||
| ARM_TENANT_ID: $(ARM_TENANT_ID) | ||
| inputs: | ||
| azureSubscription: azure-sdk-tests |
There was a problem hiding this comment.
See my other comment https://github.com/Azure/azure-sdk-for-java/pull/42635/files#r1819384979 but you should not need this PreStep and as it currently setup it will not work because we need to have the subscription match the deployment.
weshaggard
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.