Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and/or fix track 1 dead or broken stuff #42779

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JimSuplizio
Copy link
Member

Making other changes, I found some track 1 cleanup that needed to be done. There will be more cleanup incoming but that's currently pending PM deprecation feedback as, in theory, all but 1 of the track 1 libraries should be eligible for removal.

  1. sdk/cognitiveservices/ci.data.yml - azure-cognitiveservices-textanalytics was removed from sources and version_data.txt but was left in yml's Artifacts so the pipeline has been failing since then. This is just an opportunistic fix.
  2. microsoft-azure-eventgrid went EOL in 3/31/2023 and shouldn't be in our sources.
  3. The last building track 1 storage library was removed in June and yet com.microsoft.azure:microsoft-azure-storage-perf, only used by the track 1 storage libraries, was left in the source and version_data.txt.
  4. com.microsoft.azure:azure-applicationinsights-query-sample and com.microsoft.azure:azure-loganalytics-sample were removed from sources but never removed from the version file.
  5. .docsettings.yml - Clean out the entries for the libraries I was removing as well as azure-cognitiveservices-textanalytics.

When this PR is merged there are three pipelines that I will have to delete

  1. internal java - eventgrid - data
  2. public java - eventgrid - ci.data
  3. public java - eventgrid - data - ci
    Somehow there's two public pipelines both using the same yml. Both were created by the bot in May of 2021 on different days but neither has run since July of 2023. Since I'm flushing both, I will not be doing code archeology to find out why two were created.

Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving yaml changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event Grid Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants