Remove references to deprecated service Azure Spatial Anchors #43991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamistel
requested review from
weidongxu-microsoft,
haolingdong-msft,
XiaofeiCao,
ArthurMa1978 and
RamonArguelles
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @pamistel! We will review the pull request and get back to you soon. |
|
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
For mgmt SDK, removing the sample does not remove the API in code (and they are automatically generated upon your Swagger).
Please schedule an update on your specs sources https://github.com/Azure/azure-rest-api-specs/tree/main/specification/mixedreality/resource-manager
and then request a new SDK release.
Comment on lines
-134
to
-150
| #### Using the access token in a Mixed Reality client library | ||
|
|
||
| Some Mixed Reality client libraries might accept an access token in place of a credential. For example: | ||
|
|
||
| ```java | ||
| // getMixedRealityAccessTokenFromWebService is a hypothetical method that retrieves | ||
| // a Mixed Reality access token from a web service. The web service would use the | ||
| // MixedRealityStsClient and credentials to obtain an access token to be returned | ||
| // to the client. | ||
| AccessToken accessToken = getMixedRealityAccessTokenFromWebService(); | ||
|
|
||
| SpatialAnchorsAccount account = new SpatialAnchorsAccount(accountId, accountDomain); | ||
| SpatialAnchorsClient client = new SpatialAnchorsClient(account, accessToken); | ||
| ``` | ||
|
|
||
| Note: The `SpatialAnchorsClient` usage above is hypothetical and may not reflect the actual library. Consult the | ||
| documentation for the client library you're using to determine if and how this might be supported. |
There was a problem hiding this comment.
Same here. Removing the sample does not remove the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines